Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new entity naming #174

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Conversation

caibinqing
Copy link
Collaborator

@caibinqing caibinqing commented Jun 26, 2024

PR Description

This PR introduces the new way of entity naming.

Avoid setting an entity's name to a hard coded English string, instead, the name should be translated.

Reason & Detail

Here gives an example of ED device in en and zh-Hans (other languages simply copy en),

for a smooth migration, manually set "has_entity_name": True to use the new naming method, otherwise keep the original behavior.

translation_key can be None, which represents the main feature of a device.

Fully entity naming will be a huge task or may be done in later PRs.

Related issue

#98

@wuwentao
Copy link
Owner

it's really a useful feature.

@wuwentao wuwentao merged commit ca63a99 into wuwentao:master Jun 26, 2024
10 checks passed
@caibinqing caibinqing deleted the entity-naming branch June 28, 2024 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants