Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Update credo and add note on Elixir versions compatibility #93

Merged
merged 7 commits into from
Aug 20, 2024

Conversation

joaquinco
Copy link
Contributor

@joaquinco joaquinco commented Aug 15, 2024

Dependencies changes

  • Update credo (and bamboo because of a shared dependency mime) because it was raising an error locally with the locked version
  • Update credo config file from the default configuration

CI changes

  • Lint only the last version on the CI pipeline
  • Remove e2e tests from code checks step
  • Remove Elixir 1.9 from matrix run because it's not supported by the new mime version

@iaguirre88
Copy link
Member

Could we also update the other devs dependencies too? 🙏 Like bypass, dialyxir and ex_docs?

Also, are the tests failing for older versions of Elixir? I would prefer not to drop support on legacy versions of Elixir unless is really necessary

@iaguirre88
Copy link
Member

  • It seems only 1.9 version is failing on the CI so we could remove only that from the matrix
  • Also, I agree with removing the e2e during the check step but we still want to run this test in the latest version

Copy link
Member

@iaguirre88 iaguirre88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀🚀

@iaguirre88 iaguirre88 merged commit 677534b into wyeworks:master Aug 20, 2024
27 checks passed
@joaquinco joaquinco deleted the fix/credo branch September 5, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants