interface for determining scw or eoa #938
Annotations
2 errors and 8 warnings
`?` couldn't convert the error to `erc1271_verifier::VerifierError`:
xmtp_id/src/erc1271_verifier.rs#L51
error[E0277]: `?` couldn't convert the error to `erc1271_verifier::VerifierError`
--> xmtp_id/src/erc1271_verifier.rs:51:19
|
51 | .await?;
| ^ the trait `std::convert::From<ethers::ethers_contract::ContractError<ethers::ethers_providers::Provider<ethers::ethers_providers::Http>>>` is not implemented for `erc1271_verifier::VerifierError`, which is required by `std::result::Result<bool, erc1271_verifier::VerifierError>: std::ops::FromResidual<std::result::Result<std::convert::Infallible, ethers::ethers_contract::ContractError<ethers::ethers_providers::Provider<ethers::ethers_providers::Http>>>>`
|
= note: the question mark operation (`?`) implicitly performs a conversion on the error value using the `From` trait
= help: the following other types implement trait `std::ops::FromResidual<R>`:
<std::result::Result<T, F> as std::ops::FromResidual<std::ops::Yeet<E>>>
<std::result::Result<T, F> as std::ops::FromResidual<std::result::Result<std::convert::Infallible, E>>>
= note: required for `std::result::Result<bool, erc1271_verifier::VerifierError>` to implement `std::ops::FromResidual<std::result::Result<std::convert::Infallible, ethers::ethers_contract::ContractError<ethers::ethers_providers::Provider<ethers::ethers_providers::Http>>>>`
|
build
buildx failed with: ERROR: failed to solve: process "/bin/sh -c cargo check" did not complete successfully: exit code: 101
|
redundant closure:
xmtp_mls/src/groups/subscriptions.rs#L89
warning: redundant closure
--> xmtp_mls/src/groups/subscriptions.rs:89:13
|
89 | move |message| callback(message),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `callback`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
= note: `#[warn(clippy::redundant_closure)]` on by default
|
the borrowed expression implements the required traits:
xmtp_proto/src/gen/xmtp.mls.message_contents.serde.rs#L2424
warning: the borrowed expression implements the required traits
--> xmtp_proto/src/gen/xmtp.mls.message_contents.serde.rs:2424:91
|
2424 | struct_ser.serialize_field("content", pbjson::private::base64::encode(&v).as_str())?;
| ^^ help: change this to: `v`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
the borrowed expression implements the required traits:
xmtp_proto/src/gen/xmtp.mls.message_contents.serde.rs#L391
warning: the borrowed expression implements the required traits
--> xmtp_proto/src/gen/xmtp.mls.message_contents.serde.rs:391:115
|
391 | struct_ser.serialize_field("unsignedLegacyCreateIdentityKey", pbjson::private::base64::encode(&v).as_str())?;
| ^^ help: change this to: `v`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
the borrowed expression implements the required traits:
xmtp_proto/src/gen/xmtp.mls.message_contents.serde.rs#L387
warning: the borrowed expression implements the required traits
--> xmtp_proto/src/gen/xmtp.mls.message_contents.serde.rs:387:99
|
387 | struct_ser.serialize_field("installationKey", pbjson::private::base64::encode(&v).as_str())?;
| ^^ help: change this to: `v`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
the borrowed expression implements the required traits:
xmtp_proto/src/gen/xmtp.message_contents.serde.rs#L2951
warning: the borrowed expression implements the required traits
--> xmtp_proto/src/gen/xmtp.message_contents.serde.rs:2951:86
|
2951 | struct_ser.serialize_field("senderHmac", pbjson::private::base64::encode(&v).as_str())?;
| ^^ help: change this to: `v`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
the borrowed expression implements the required traits:
xmtp_proto/src/gen/xmtp.message_contents.serde.rs#L1334
warning: the borrowed expression implements the required traits
--> xmtp_proto/src/gen/xmtp.message_contents.serde.rs:1334:86
|
1334 | struct_ser.serialize_field("v1", pbjson::private::base64::encode(&v).as_str())?;
| ^^ help: change this to: `v`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
|
build
This job failure may be caused by using an out of date self-hosted runner. You are currently using runner version 2.314.1. Please update to the latest version 2.315.0
|
build
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: docker/build-push-action@v4. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|