Add API trait #647
Merged
Add API trait #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 10, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. |
neekolas
commented
Apr 10, 2024
| request: PublishIdentityUpdateRequest, | ||
| ) -> Result<PublishIdentityUpdateResponse, Error>; | ||
|
|
||
| async fn get_identity_updates_v2( |
There was a problem hiding this comment.
Needed to make this a v2 since we already have a get_identity_updates method on the client for the old endpoint.
There was a problem hiding this comment.
To clarify, get_identity_updates_v2 is getting xmtp v3 identities right?
richardhuaaa
approved these changes
Apr 10, 2024
neekolas
force-pushed
the
04-10-add_api_trait
branch
from
40f2a3b to
2b4ba2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tl;dr
grpc_api_clientTODO
The backend for this doesn't exist, so we can't really write any tests yet. Just putting this in so that we're ready.