-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add API trait #647
Merged
Merged
Add API trait #647
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,62 @@ | ||
use tonic::{async_trait, Request}; | ||
use xmtp_proto::{ | ||
api_client::{Error, ErrorKind, XmtpIdentityClient}, | ||
xmtp::identity::api::v1::{ | ||
GetIdentityUpdatesRequest as GetIdentityUpdatesV2Request, | ||
GetIdentityUpdatesResponse as GetIdentityUpdatesV2Response, GetInboxIdsRequest, | ||
GetInboxIdsResponse, PublishIdentityUpdateRequest, PublishIdentityUpdateResponse, | ||
}, | ||
}; | ||
|
||
use crate::Client; | ||
|
||
#[async_trait] | ||
impl XmtpIdentityClient for Client { | ||
async fn publish_identity_update( | ||
&self, | ||
request: PublishIdentityUpdateRequest, | ||
) -> Result<PublishIdentityUpdateResponse, Error> { | ||
let mut tonic_request = Request::new(request); | ||
tonic_request | ||
.metadata_mut() | ||
.insert("x-app-version", self.app_version.clone()); | ||
let client = &mut self.identity_client.clone(); | ||
|
||
let res = client.publish_identity_update(tonic_request).await; | ||
|
||
res.map(|response| response.into_inner()) | ||
.map_err(|err| Error::new(ErrorKind::IdentityError).with(err)) | ||
} | ||
|
||
async fn get_inbox_ids( | ||
&self, | ||
request: GetInboxIdsRequest, | ||
) -> Result<GetInboxIdsResponse, Error> { | ||
let mut tonic_request = Request::new(request); | ||
tonic_request | ||
.metadata_mut() | ||
.insert("x-app-version", self.app_version.clone()); | ||
let client = &mut self.identity_client.clone(); | ||
|
||
let res = client.get_inbox_ids(tonic_request).await; | ||
|
||
res.map(|response| response.into_inner()) | ||
.map_err(|err| Error::new(ErrorKind::IdentityError).with(err)) | ||
} | ||
|
||
async fn get_identity_updates_v2( | ||
&self, | ||
request: GetIdentityUpdatesV2Request, | ||
) -> Result<GetIdentityUpdatesV2Response, Error> { | ||
let mut tonic_request = Request::new(request); | ||
tonic_request | ||
.metadata_mut() | ||
.insert("x-app-version", self.app_version.clone()); | ||
let client = &mut self.identity_client.clone(); | ||
|
||
let res = client.get_identity_updates(tonic_request).await; | ||
|
||
res.map(|response| response.into_inner()) | ||
.map_err(|err| Error::new(ErrorKind::IdentityError).with(err)) | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needed to make this a
v2
since we already have aget_identity_updates
method on the client for the old endpoint.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To clarify,
get_identity_updates_v2
is getting xmtp v3 identities right?