Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix group update #654

Closed
wants to merge 4 commits into from
Closed

Fix group update #654

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6cbd27e
fix: updates generated protos
tuddman Apr 12, 2024
9d1cb59
feat: adds update_group_policy_set
tuddman Apr 12, 2024
fefabaa
fix: lint
tuddman Apr 12, 2024
8c61799
Merge branch 'main' into st/fix-group-update
tuddman Apr 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions xmtp_mls/src/groups/group_permissions.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,8 +244,8 @@
Self {
add_member_policy,
remove_member_policy,
add_installation_policy: default_add_installation_policy(),

Check failure on line 247 in xmtp_mls/src/groups/group_permissions.rs

View workflow job for this annotation

GitHub Actions / workspace

cannot find function `default_add_installation_policy` in this scope 

error[E0425]: cannot find function `default_add_installation_policy` in this scope
   --> xmtp_mls/src/groups/group_permissions.rs:247:38
    |
247 |             add_installation_policy: default_add_installation_policy(),
    |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ not found in this scope
remove_installation_policy: default_remove_installation_policy(),

Check failure on line 248 in xmtp_mls/src/groups/group_permissions.rs

View workflow job for this annotation

GitHub Actions / workspace

cannot find function `default_remove_installation_policy` in this scope 

error[E0425]: cannot find function `default_remove_installation_policy` in this scope
   --> xmtp_mls/src/groups/group_permissions.rs:248:41
    |
248 |             remove_installation_policy: default_remove_installation_policy(),
    |                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ not found in this scope
update_group_name_policy,
}
}
Expand Down Expand Up @@ -333,14 +333,6 @@
}
}

fn default_add_installation_policy() -> MembershipPolicies {
MembershipPolicies::allow()
}

fn default_remove_installation_policy() -> MembershipPolicies {
MembershipPolicies::deny()
}
Comment on lines -336 to -342
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These seemed like a bit of needless indirection to only be called in the new() constructor above.


/// A policy where any member can add or remove any other member
pub(crate) fn policy_everyone_is_admin() -> PolicySet {
PolicySet::new(
Expand Down
Loading