Fix group update #654
Closed
Fix group update #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuddman
commented
Apr 12, 2024
Comment on lines
-327
to
-342
| fn default_add_installation_policy() -> MembershipPolicies { | ||
| MembershipPolicies::allow() | ||
| } | ||
|
|
||
| fn default_remove_installation_policy() -> MembershipPolicies { | ||
| MembershipPolicies::deny() | ||
| } |
There was a problem hiding this comment.
These seemed like a bit of needless indirection to only be called in the new() constructor above.
tuddman
commented
Apr 12, 2024
| remove_installation_policy: default_remove_installation_policy(), | ||
| add_installation_policy: MembershipPolicies::allow(), | ||
| remove_installation_policy: MembershipPolicies::deny(), | ||
| update_group_name_policy: MembershipPolicies::allow() |
There was a problem hiding this comment.
@cameronvoell What should this update_group_name_policy be default set to?
cc @neekolas
Merged
|
Closing. The sames fixes were brought in #643 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After issue-ing
dev/gen-proto.sh,Tests were failing with
This patch fixes the acute issue of the missing field, but idk if there is more work to do here to have it correctly implemented?