feat: adds missing installations when group is synced (#492)
workspace
6 warnings
Details
Results
| Message level | Amount |
|---|---|
| Internal compiler error | 0 |
| Error | 0 |
| Warning | 6 |
| Note | 0 |
| Help | 0 |
Versions
- rustc 1.75.0 (82e1608df 2023-12-21)
- cargo 1.75.0 (1d8b05cdd 2023-11-20)
- clippy 0.1.75 (82e1608 2023-12-21)
Annotations
Check warning on line 66 in xmtp_mls/src/groups/sync.rs
github-actions / workspace
this expression creates a reference which is immediately dereferenced by the compiler
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> xmtp_mls/src/groups/sync.rs:66:49
|
66 | let provider = self.client.mls_provider(&conn);
| ^^^^^ help: change this to: `conn`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
Check warning on line 98 in xmtp_mls/src/credential/validated_legacy_signed_public_key.rs
github-actions / workspace
redundant field names in struct initialization
warning: redundant field names in struct initialization
--> xmtp_mls/src/credential/validated_legacy_signed_public_key.rs:98:13
|
98 | serialized_key_data: serialized_key_data,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `serialized_key_data`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
Check warning on line 97 in xmtp_mls/src/credential/validated_legacy_signed_public_key.rs
github-actions / workspace
redundant field names in struct initialization
warning: redundant field names in struct initialization
--> xmtp_mls/src/credential/validated_legacy_signed_public_key.rs:97:13
|
97 | wallet_signature: wallet_signature,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `wallet_signature`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
= note: `#[warn(clippy::redundant_field_names)]` on by default
Check warning on line 395 in xmtp_proto/src/gen/xmtp.mls.message_contents.serde.rs
github-actions / workspace
the borrowed expression implements the required traits
warning: the borrowed expression implements the required traits
--> xmtp_proto/src/gen/xmtp.mls.message_contents.serde.rs:395:115
|
395 | struct_ser.serialize_field("unsignedLegacyCreateIdentityKey", pbjson::private::base64::encode(&v).as_str())?;
| ^^ help: change this to: `v`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
Check warning on line 392 in xmtp_proto/src/gen/xmtp.mls.message_contents.serde.rs
github-actions / workspace
the borrowed expression implements the required traits
warning: the borrowed expression implements the required traits
--> xmtp_proto/src/gen/xmtp.mls.message_contents.serde.rs:392:99
|
392 | struct_ser.serialize_field("installationKey", pbjson::private::base64::encode(&v).as_str())?;
| ^^ help: change this to: `v`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
Check warning on line 1329 in xmtp_proto/src/gen/xmtp.message_contents.serde.rs
github-actions / workspace
the borrowed expression implements the required traits
warning: the borrowed expression implements the required traits
--> xmtp_proto/src/gen/xmtp.message_contents.serde.rs:1329:86
|
1329 | struct_ser.serialize_field("v1", pbjson::private::base64::encode(&v).as_str())?;
| ^^ help: change this to: `v`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default