Skip to content

feat: adds missing installations when group is synced (#492)

Sign in for the full log view
GitHub Actions / ffi succeeded Feb 8, 2024 in 0s

ffi

6 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 6
Note 0
Help 0

Versions

  • rustc 1.75.0 (82e1608df 2023-12-21)
  • cargo 1.75.0 (1d8b05cdd 2023-11-20)
  • clippy 0.1.75 (82e1608 2023-12-21)

Annotations

Check warning on line 227 in src/v2.rs

See this annotation in the file changed.

@github-actions github-actions / ffi

unneeded `return` statement 

warning: unneeded `return` statement
   --> src/v2.rs:223:17
    |
223 | /                 return PagingInfo {
224 | |                     limit: paging_info.limit,
225 | |                     direction: paging_info.direction as i32,
226 | |                     cursor: None, // TODO: fix me
227 | |                 };
    | |_________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
    |
223 ~                 PagingInfo {
224 +                     limit: paging_info.limit,
225 +                     direction: paging_info.direction as i32,
226 +                     cursor: None, // TODO: fix me
227 ~                 }
    |

Check warning on line 212 in src/v2.rs

See this annotation in the file changed.

@github-actions github-actions / ffi

unneeded `return` statement 

warning: unneeded `return` statement
   --> src/v2.rs:208:17
    |
208 | /                 return FfiPagingInfo {
209 | |                     limit: paging_info.limit,
210 | |                     direction: FfiSortDirection::from_i32(paging_info.direction),
211 | |                     cursor: None,
212 | |                 };
    | |_________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
    |
208 ~                 FfiPagingInfo {
209 +                     limit: paging_info.limit,
210 +                     direction: FfiSortDirection::from_i32(paging_info.direction),
211 +                     cursor: None,
212 ~                 }
    |

Check warning on line 191 in src/v2.rs

See this annotation in the file changed.

@github-actions github-actions / ffi

unneeded `return` statement 

warning: unneeded `return` statement
   --> src/v2.rs:187:17
    |
187 | /                 return FfiPagingInfo {
188 | |                     limit: paging_info.limit,
189 | |                     direction: FfiSortDirection::from_i32(paging_info.direction),
190 | |                     cursor: proto_cursor_to_ffi(paging_info.cursor),
191 | |                 };
    | |_________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
    |
187 ~                 FfiPagingInfo {
188 +                     limit: paging_info.limit,
189 +                     direction: FfiSortDirection::from_i32(paging_info.direction),
190 +                     cursor: proto_cursor_to_ffi(paging_info.cursor),
191 ~                 }
    |

Check warning on line 174 in src/v2.rs

See this annotation in the file changed.

@github-actions github-actions / ffi

unneeded `return` statement 

warning: unneeded `return` statement
   --> src/v2.rs:170:17
    |
170 | /                 return PagingInfo {
171 | |                     limit: paging_info.limit,
172 | |                     direction: paging_info.direction as i32,
173 | |                     cursor: paging_info.cursor.map(|c| c.into()), // TODO: fix me
174 | |                 };
    | |_________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
    = note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
    |
170 ~                 PagingInfo {
171 +                     limit: paging_info.limit,
172 +                     direction: paging_info.direction as i32,
173 +                     cursor: paging_info.cursor.map(|c| c.into()), // TODO: fix me
174 ~                 }
    |

Check warning on line 390 in src/mls.rs

See this annotation in the file changed.

@github-actions github-actions / ffi

this expression creates a reference which is immediately dereferenced by the compiler 

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> src/mls.rs:390:39
    |
390 |             let group = MlsGroup::new(&client, group_id, created_at_ns);
    |                                       ^^^^^^^ help: change this to: `client`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
    = note: `#[warn(clippy::needless_borrow)]` on by default

Check warning on line 55 in src/mls.rs

See this annotation in the file changed.

@github-actions github-actions / ffi

this function has too many arguments (8/7) 

warning: this function has too many arguments (8/7)
  --> src/mls.rs:46:1
   |
46 | / pub async fn create_client(
47 | |     logger: Box<dyn FfiLogger>,
48 | |     host: String,
49 | |     is_secure: bool,
...  |
54 | |     legacy_signed_private_key_proto: Option<Vec<u8>>,
55 | | ) -> Result<Arc<FfiXmtpClient>, GenericError> {
   | |_____________________________________________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
   = note: `#[warn(clippy::too_many_arguments)]` on by default
View more details on GitHub Actions