Add a options to fix ignore "expire within" error #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This error is the same as "the password will expire within" but not ignore. So I write this to let different country use different localized oracle databases can ignore as same as the English version.
fix format
|
Thank you for the PR. Can you please provide some snippets on how to use this feature? I think the ignore error messages will be added in the config? |
Yes, It will be added in the options like this. In some cases that the Oracle Exception may be displayed as more than one language, so I set this config as an array. The full config can be like the image below.
|
yajra
requested changes
Nov 26, 2024
| if (! str_contains($e['message'], 'the password will expire within')) { | ||
| $ignoreMessageList = array_key_exists('ignore_error_messages', $options) ? $options['ignore_error_messages'] : ['the password will expire within']; | ||
|
|
||
| $flag = true; |
There was a problem hiding this comment.
Can we rename this to $throwError for easier review in the future?
Other than this, the changes look good. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is want to be fix about this:
This error is the same as "the password will expire within" but not ignore. So I write this to let different country use different localized oracle databases can ignore as same as the English version.
I am sorry that I do't use this in a long time, so make some error about the old pr.