Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a options to fix ignore "expire within" error #148

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add a options to fix ignore "expire within" error #148

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a328e1
Add a options to fix ignore "expire within" error
lijialong1313 Nov 18, 2024
d89924a
Update Oci8.php
lijialong1313 Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/Pdo/Oci8.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,17 @@ private function connect(string $dsn, string $username, string $password, array
if (! $this->dbh) {
$e = oci_error();

if (! str_contains($e['message'], 'the password will expire within')) {
$ignoreMessageList = array_key_exists('ignore_error_messages', $options) ? $options['ignore_error_messages'] : ['the password will expire within'];

$flag = true;
Copy link
Owner

@yajra yajra Nov 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rename this to $throwError for easier review in the future?

Other than this, the changes look good. Thanks!


foreach ($ignoreMessageList as $str) {
if (str_contains($e['message'], $str)) {
$flag = false;
}
}

if ($flag) {
throw new Oci8Exception($e['message'], $e['code']);
}
}
Expand Down