Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust titles when selecting drawer #1435

Merged
merged 9 commits into from
Apr 15, 2024
Merged

Conversation

lequ0n
Copy link
Contributor

@lequ0n lequ0n commented Dec 21, 2023

No description provided.

@lequ0n lequ0n linked an issue Dec 21, 2023 that may be closed by this pull request
@lequ0n lequ0n linked an issue Dec 21, 2023 that may be closed by this pull request
@grzanka grzanka marked this pull request as ready for review January 10, 2024 19:17
@grzanka grzanka removed a link to an issue Mar 7, 2024
@grzanka grzanka changed the title Full WCAG compliance Adjust titles when selecting drawer Mar 7, 2024
@grzanka grzanka added the wcag Issues related to WCAG suuport label Mar 7, 2024
Copy link
Member

@Derstilon Derstilon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few suggestions:

If there will be any new tab added to the drawer, this tab title handler will not know that and will display a default title until someone adds the handle for that.
Possible Solutions:

  • Create an object type that has all index names. Use those values as indices for TabPanel.

    <TabPanel
    value={tabsValue}
    index={'editor'}
    Enforce that each possible index has a title label defined and referenced in the hook setting web browser tab title.

  • Right now all labels are just indices transformed from camelCase to Sentence case. You could just make a helper function that does exactly that and there will be no need for objects like this:

    const tabTitles = {
    login: 'Login',
    editor: 'Editor',
    inputFiles: 'Input files',
    simulations: 'Simulations',
    results: 'Results',
    about: 'About'
    };

@grzanka
Copy link
Contributor

grzanka commented Mar 20, 2024

Screenshot 2024-03-20 at 08 23 27

@NiEkOKsU please fix conflicts. Check latests merged PR and see what has happened to the submodules, i.e. here #1536
Also converter submodule should point to the same version as in master.

@grzanka grzanka enabled auto-merge April 15, 2024 15:03
@grzanka grzanka added this pull request to the merge queue Apr 15, 2024
Merged via the queue into master with commit e87e8a6 Apr 15, 2024
10 checks passed
@grzanka grzanka deleted the 1399-full-wcag-compliance branch April 15, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wcag Issues related to WCAG suuport
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjust title
4 participants