Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust titles when selecting drawer #1435

Merged
merged 9 commits into from
Apr 15, 2024
Merged

Adjust titles when selecting drawer #1435

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b537861
Adjust title to follow selected panel
lequ0n Dec 21, 2023
3f0f955
Update src/ThreeEditor/components/Editor/EditorAppBar/components/Edit…
grzanka Mar 7, 2024
d67ea46
Make a code adjusting title cleaner
NiEkOKsU Mar 19, 2024
33ee28d
add explaining comment
NiEkOKsU Mar 20, 2024
045f4ec
resolve jsroot conflict
NiEkOKsU Mar 20, 2024
73186d4
Move changing text case logic to dedicated function
NiEkOKsU Mar 20, 2024
e7db2c6
added comment
NiEkOKsU Mar 20, 2024
fab37e4
resolve confilct with converter
NiEkOKsU Apr 1, 2024
21fa29d
Adding a comment to describe purpose of usage
NiEkOKsU Apr 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/ThreeEditor/components/Editor/EditorAppBar/components/EditorTitlebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ export function EditorTitleBar() {
const [editMode, setEditMode] = useState(false);
const [title, setTitle] = useState<string>(yaptideEditor?.config.getKey('project/title'));
const titleRef = useRef(title);
useDocumentTitle(titleRef.current);
grzanka marked this conversation as resolved.
Show resolved Hide resolved

const startSave = useCallback(() => {
setSaving(true);
Expand Down
12 changes: 12 additions & 0 deletions src/WrapperApp/WrapperApp.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,18 @@ function WrapperApp() {
if (isAuthorized && tabsValue === 'login') setTabsValue('editor');
}, [isAuthorized, tabsValue]);

useEffect(() => {
const tabTitles = {
login: 'Login',
editor: 'Editor',
inputFiles: 'Input files',
simulations: 'Simulations',
results: 'Results',
about: 'About'
};
document.title = `${tabTitles[tabsValue as keyof typeof tabTitles] || 'Yaptide'}`;
}, [tabsValue]);

return (
<Box
sx={{
Expand Down
Loading