Add validation for activation code and error logging for createFamily in Parent Signup flow #1014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report
File CoverageNo changed files found. |
|
Visit the preview URL for this PR (updated for commit 4388960): https://roar-staging--pr1014-enh-parent-signup-te-7p1petwj.web.app (expires Fri, 07 Feb 2025 19:15:24 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460 |
roar-dashboard-e2e
|
||||||||||||||||||||||||||||
| Project |
roar-dashboard-e2e
|
| Branch Review |
enh/parent-signup-text
|
| Run status |
|
| Run duration | 05m 45s |
| Commit |
|
| Committer | Adam Richie-Halford |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
14
|
| View all changes introduced in this branch ↗︎ | |
richford
requested changes
Jan 22, 2025
Co-authored-by: Adam Richie-Halford <[email protected]>
lucasxsong
changed the title
Emily-ejag
previously approved these changes
Jan 27, 2025
ksmontville
requested changes
Jan 30, 2025
| showErrorDialog(); | ||
| submitted.value = false; |
There was a problem hiding this comment.
Just want to double check that this line was intentionally removed, and not by mistake.
Is this because we want to trigger the conditional rendering of the error messages based on submitted being true after we attempt to submit the form?
There was a problem hiding this comment.
That is correct, previously the submitted.value = false would prevent the error message from rendering.
Emily-ejag
approved these changes
Jan 30, 2025
richford
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Types of changes
What types of changes does this pull request introduce?
Checklist
Justification of missing checklist items
Further comments