-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add validation for activation code and error logging for createFamily in Parent Signup flow #1014
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
5cd59ed
edit text to include roar research portal
lucasxsong 768fbf8
Update src/pages/RegisterFamilyUsers.vue
lucasxsong 4c1bb4b
add validation for activation code expiration based on time based com…
lucasxsong 26dbfff
add validation for activation code expiration based on time based com…
lucasxsong d24b912
add error message for post-submission
lucasxsong 32c9907
remove extraneous import
lucasxsong 7069a38
Merge branch 'main' into enh/parent-signup-text
lucasxsong 1e9d944
fix error validation for miniumum character password input
lucasxsong c340f90
fix issue where password mismatch still allows submit
lucasxsong b401423
update to use dateExpired to check expiration
lucasxsong d166dd6
increasing time for ci build
Emily-ejag 4388960
Merge branch 'main' into enh/parent-signup-text
richford File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just want to double check that this line was intentionally removed, and not by mistake.
Is this because we want to trigger the conditional rendering of the error messages based on
submitted
being true after we attempt to submit the form?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is correct, previously the submitted.value = false would prevent the error message from rendering.