-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit tests #176
Add unit tests #176
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #176 +/- ##
=============================================
+ Coverage 48.52% 77.90% +29.37%
Complexity 400 400
=============================================
Files 59 59
Lines 1088 1086 -2
=============================================
+ Hits 528 846 +318
+ Misses 560 240 -320 ☔ View full report in Codecov by Sentry. |
PR SummaryModifications in Command Files
New Test Files and Test CaseMany new test files were added, particularly focusing on testing command migrations, and schema aspects. This amplifies the testing suite and improves the robustness of the repository. Additionally, a new test case was added to File Renaming and TweakingVarious test files were renamed to make their naming more descriptive or moved to better located directories. This helps maintain the clarity and organization of your repository's testing framework. New ClassesNew classes Overall BenefitsThese changes enhance code maintainability and readability. They pave the way for a more robust testing environment and also help in managing user interactions better. |
Part of #22
What was changed
Yiisoft\Yii\Cycle\Command\Migration\DownCommand
the unused variable $exist was removed and the result of the rollback method was added to the $migration variable. This method returns the migration to which the rollback was applied and it contains the new status.Yiisoft\Yii\Cycle\Command\Migration\GenerateCommand
the retrieval of the helper has been moved to the block with the condition $input->isInteractive(), as it is only used within it.Yiisoft\Yii\Cycle\Factory\RepositoryContainer
class, the private property rootContainer has been removed. It was only set in the constructor and was not used anywhere else.