Https Connections Instead of Http #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ehatch90 , that will work just fine for some scenarios. But it will also break anything running KairosDB on regular HTTP, which afaik is most folks. So at a minimum, this would have to be configurable via tscached.yaml. It might actually be easier, in this case, to change the config file format to just take the whole URL rather than adding a third variable. Also, what happens if you configure kairosdb with a non-standard cert? Probably above the MVP, but worth keeping in mind :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a minor fix but it might help others who need a quick https changeover. Please let me know if other changes need to be made for acceptance and I will do my best to make them.