-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(refactor) make RetryException constructor public #1657
(refactor) make RetryException constructor public #1657
Conversation
@puncleV than you for this suggestion. Can you please describe a sample use-case related to this change in the https://github.com/zalando/riptide/blob/main/riptide-failsafe/README.md ? |
9cb5da7
to
4651ab3
Compare
@fatroom yes, no problem, was fighting with gpg key to sign the commit. :D |
@puncleV can you merge main branch here to pickup dependency changes? |
@fatroom done |
Thank you for your contribution! |
First of many! (Or at least few more, maybe…) :D |
Make
RetryException
constructor public to allow using it in the code for easily retry whenever it's needed.Description
The RetryException which is used for default Failsafe retry handling is now package private which prevents the users from easily introduce retries into their code which have specific cases.
Motivation and Context
Use case: i want to be able to retry specific
400
responses but not all of them, right now i have to define my own failsafe plugin or do some extra steps vs. just importing theRetryException
and use it where i see fit.Example on Kotlin:
Types of changes
Checklist: