Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PDF: Handle keyboard contextmenu events #141

Merged
merged 1 commit into from
Oct 17, 2024
Merged

PDF: Handle keyboard contextmenu events #141

merged 1 commit into from
Oct 17, 2024

Conversation

AbeJellinek
Copy link
Member

@AbeJellinek AbeJellinek commented Oct 7, 2024 •
edited
Loading

@AbeJellinek AbeJellinek requested a review from mrtcode October 7, 2024 20:54
@AbeJellinek AbeJellinek mentioned this pull request Oct 7, 2024
Merged
@AbeJellinek AbeJellinek marked this pull request as draft October 7, 2024 20:56
@AbeJellinek AbeJellinek force-pushed the handle-keyboard-context-menu branch from ec6cd87 to 82761a7 Compare October 7, 2024 20:56
@AbeJellinek AbeJellinek marked this pull request as ready for review October 7, 2024 20:56
mrtcode
mrtcode reviewed Oct 8, 2024
View reviewed changes
Copy link
Member

@mrtcode mrtcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But don’t we also want to show an annotation context menu when an annotation is selected?

src/pdf/pdf-view.js Outdated Show resolved Hide resolved
@AbeJellinek AbeJellinek force-pushed the handle-keyboard-context-menu branch from 82761a7 to 35e650a Compare October 16, 2024 14:56
@AbeJellinek
Copy link
Member Author

OK, updated. This should be ready. I'll work on annotation separately (thanks, I don't know how I missed that!) - not specific to PDF.

@dstillman dstillman merged commit 358fb6e into zotero:master Oct 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrtcode mrtcode mrtcode left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AbeJellinek @mrtcode @dstillman