Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDF: Handle keyboard contextmenu events #141

Merged
merged 1 commit into from
Oct 17, 2024
Merged

PDF: Handle keyboard contextmenu events #141

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions src/pdf/pdf-view.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1684,7 +1684,21 @@ class PDFView {
if (position) {
overlay = this._getSelectableOverlay(position);
}
this._onOpenViewContextMenu({ x: br.x + event.clientX, y: br.y + event.clientY, overlay });
// If this is a keyboard contextmenu event, its position won't take our
// text selection into account since we don't use browser selection APIs.
// Position the menu manually.
if (event.mozInputSource === 6 && this._selectionRanges.length) {
const EXTRA_VERTICAL_PADDING = 10;
let selectionBoundingRect = this.getClientRectForPopup(this._selectionRanges[0].position);
this._onOpenViewContextMenu({
x: br.x + selectionBoundingRect[0],
y: br.y + selectionBoundingRect[3] + EXTRA_VERTICAL_PADDING,
overlay
});
}
else {
this._onOpenViewContextMenu({ x: br.x + event.clientX, y: br.y + event.clientY, overlay });
}
}
else if (!selectedAnnotations.includes(selectableAnnotation)) {
this._onSelectAnnotations([selectableAnnotation.id], event);
Expand Down Expand Up @@ -2498,8 +2512,8 @@ class PDFView {
}

_handleContextMenu(event) {
// Open context menu on long press of touchscreen
if (event.mozInputSource === 5) {
// Open context menu due to touchscreen long press or context menu key press
if (event.mozInputSource === 5 || event.mozInputSource === 6) {
this._handlePointerDown(event);
}
if (this._options.platform !== 'web') {
Expand Down
Loading