Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PC: Ensure Uniqueness of SoA Names #4299

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Jan 17, 2025

Summary

Avoid user errors. Happened immediately to me: I added a runtime component with the same name as a compile-time SoA component and no error was thrown (now it will).

Additional background

AMReX-Codes/pyamrex#382

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

@ax3l ax3l added the bug label Jan 17, 2025
@ax3l ax3l requested a review from atmyers January 17, 2025 23:32
@ax3l ax3l assigned ax3l and atmyers and unassigned ax3l Jan 17, 2025
@ax3l
Copy link
Member Author

ax3l commented Jan 18, 2025

@WeiqunZhang @atmyers I think the CI failures here are unrelated.

@ax3l ax3l mentioned this pull request Jan 18, 2025
6 tasks
@WeiqunZhang
Copy link
Member

For the PETSc test, I have been seeing it fails in my fork too. The issue is in the installation script. Maybe we should switch to a newer version.

For ICC test, I don't know. We can try to rerun it. We might also consider removing it because it is deprecated.

@ax3l ax3l changed the title SoA Names: Ensure Uniqueness PC: Ensure Uniqueness of SoA Names Jan 18, 2025
@ax3l
Copy link
Member Author

ax3l commented Jan 18, 2025

I restarted ICC already a few times. But admittedly, the original ICC is dead and EOL since over a year or so now. We could remove it.

icpc: remark #10441: The Intel(R) C++ Compiler Classic (ICC) is deprecated and will be removed from product release in the second half of 2023. The Intel(R) oneAPI DPC++/C++ Compiler (ICX) is the recommended compiler moving forward. Please transition to use this compiler. Use '-diag-disable=10441' to disable this message.

@ax3l ax3l mentioned this pull request Jan 18, 2025
5 tasks
@ax3l
Copy link
Member Author

ax3l commented Jan 18, 2025

This is ready. I opened another PR to remove ICC from CI.

@ax3l ax3l requested a review from WeiqunZhang January 18, 2025 01:52
WeiqunZhang pushed a commit that referenced this pull request Jan 18, 2025
## Summary

Fails now in CI. For a while it remarks:
> icpc: remark #10441: The Intel(R) C++ Compiler Classic (ICC) is
deprecated and will be removed from product release in the second half
of 2023. The Intel(R) oneAPI DPC++/C++ Compiler (ICX) is the recommended
compiler moving forward. Please transition to use this compiler. Use
'-diag-disable=10441' to disable this message.

## Additional background

#4299 (comment)
Avoid user errors. Happened immediately to me: I added
a runtime component with the same name as a compile-time SoA
component and no error was thrown (now it will).
@ax3l ax3l force-pushed the fix-add-comp-unique branch from 6152178 to 3baf9fe Compare January 18, 2025 06:19
@atmyers atmyers merged commit 66e83ea into AMReX-Codes:development Jan 21, 2025
74 checks passed
@ax3l ax3l deleted the fix-add-comp-unique branch January 21, 2025 18:30
ax3l added a commit that referenced this pull request Jan 21, 2025
## Summary

Add name to index getters and query (has) functions to SoA names. Ported
over from ImpactX.

- [x] Rebase after #4299 was merged

## Additional background

ECP-WarpX/impactx#805

## Checklist

The proposed changes:
- [ ] fix a bug or incorrect behavior in AMReX
- [x] add new capabilities to AMReX
- [ ] changes answers in the test suite to more than roundoff level
- [ ] are likely to significantly affect the results of downstream AMReX
users
- [ ] include documentation in the code and/or rst files, if appropriate
ax3l added a commit to AMReX-Codes/pyamrex that referenced this pull request Jan 23, 2025
Update to latest commit in `development`.
Pull in fixes
- [x] AMReX-Codes/amrex#4298
- [x] AMReX-Codes/amrex#4299
- [x] AMReX-Codes/amrex#4302
- [x] AMReX-Codes/amrex#4300

for #382.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants