-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PC: Ensure Uniqueness of SoA Names #4299
Conversation
@WeiqunZhang @atmyers I think the CI failures here are unrelated. |
For the PETSc test, I have been seeing it fails in my fork too. The issue is in the installation script. Maybe we should switch to a newer version. For ICC test, I don't know. We can try to rerun it. We might also consider removing it because it is deprecated. |
I restarted ICC already a few times. But admittedly, the original ICC is dead and EOL since over a year or so now. We could remove it.
|
This is ready. I opened another PR to remove ICC from CI. |
## Summary Fails now in CI. For a while it remarks: > icpc: remark #10441: The Intel(R) C++ Compiler Classic (ICC) is deprecated and will be removed from product release in the second half of 2023. The Intel(R) oneAPI DPC++/C++ Compiler (ICX) is the recommended compiler moving forward. Please transition to use this compiler. Use '-diag-disable=10441' to disable this message. ## Additional background #4299 (comment)
Avoid user errors. Happened immediately to me: I added a runtime component with the same name as a compile-time SoA component and no error was thrown (now it will).
6152178
to
3baf9fe
Compare
## Summary Add name to index getters and query (has) functions to SoA names. Ported over from ImpactX. - [x] Rebase after #4299 was merged ## Additional background ECP-WarpX/impactx#805 ## Checklist The proposed changes: - [ ] fix a bug or incorrect behavior in AMReX - [x] add new capabilities to AMReX - [ ] changes answers in the test suite to more than roundoff level - [ ] are likely to significantly affect the results of downstream AMReX users - [ ] include documentation in the code and/or rst files, if appropriate
Update to latest commit in `development`. Pull in fixes - [x] AMReX-Codes/amrex#4298 - [x] AMReX-Codes/amrex#4299 - [x] AMReX-Codes/amrex#4302 - [x] AMReX-Codes/amrex#4300 for #382.
Summary
Avoid user errors. Happened immediately to me: I added a runtime component with the same name as a compile-time SoA component and no error was thrown (now it will).
Additional background
AMReX-Codes/pyamrex#382
Checklist
The proposed changes: