[Archived] Feature/memory patch #487
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonMarechal25
force-pushed
the
feature/memory_patch
branch
from
b63c61d to
1a5faa3
Compare
JasonMarechal25
requested review from
sgatto,
a-zakir and
tbittar
and removed request for
sgatto
tbittar
reviewed
Jul 27, 2022
| return std::make_shared<SubproblemWorker>( | ||
| kvp.second, GetSubproblemPath(kvp.first), | ||
| SubproblemWeight(_data.nsubproblem, kvp.first), Options().SOLVER_NAME, | ||
| Options().LOG_LEVEL, log_name()); |
There was a problem hiding this comment.
Why do we use Options() instaed of options_ ?
There was a problem hiding this comment.
It makes no difference, Options() is just a getter on options_
| @@ -103,6 +103,7 @@ class Problem: public SolverAbstract | |||
| void set_simplex_iter(int iter) override { solver_abstract_->set_simplex_iter(iter);} | |||
| void write_basis(const std::filesystem::path &filename) override { solver_abstract_->write_basis(filename); } | |||
| void read_basis(const std::filesystem::path &filename) override { solver_abstract_->read_basis(filename); } | |||
| void SetBasis(std::vector<int> rstatus, std::vector<int> cstatus) override { solver_abstract_->SetBasis(rstatus, cstatus); } | |||
There was a problem hiding this comment.
Why do you chose a different formatting in the function name compared to the other functions of the class ? (Because the input data type is different ?)
There was a problem hiding this comment.
That's a difficult point.
On one hand we should keep formatting homogeneous in files, on another hand is we don't take the habits to use our chosen format we will never do.
JasonMarechal25
force-pushed
the
feature/memory_patch
branch
from
bccd3a1 to
a743998
Compare
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.