Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the SULILGH7 flight controller board #29209

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SULILG
Copy link
Contributor

@SULILG SULILG commented Feb 1, 2025

No description provided.

@Hwurzburg
Copy link
Collaborator

needs readme and images/pinout....ala https://github.com/ArduPilot/ardupilot/tree/master/libraries/AP_HAL_ChibiOS/hwdef/AET-H743-Basic
I suggest a separate PR to reserve the bd id, instead on including it here...those get merged fast and holds the id until this gets finished and reviewed

@SULILG
Copy link
Contributor Author

SULILG commented Feb 2, 2025

I will add some images and descriptions.

Copy link
Collaborator

@Hwurzburg Hwurzburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still suggest you reserve the board id by splitting out the board_types.txt into a new PR by itself

@SULILG SULILG requested a review from Hwurzburg February 2, 2025 16:34
Copy link
Collaborator

@Hwurzburg Hwurzburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I think @andyp1per would suggest trying to make at least four PWM outputs bi-directional DShot...

Copy link
Contributor

@peterbarker peterbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit list needs fixing to conform to our standards

@SULILG SULILG requested a review from peterbarker February 4, 2025 01:04
@SULILG SULILG closed this Feb 4, 2025
@SULILG SULILG reopened this Feb 4, 2025
@Hwurzburg
Copy link
Collaborator

should be two commits:There should be only the Tools:add SULIGH7-P1-P2 commit and a hwdef:add SULIGH7-P1-P2 commit.

@SULILG
Copy link
Contributor Author

SULILG commented Feb 4, 2025

should be two commits:There should be only the Tools:add SULIGH7-P1-P2 commit and a hwdef:add SULIGH7-P1-P2 commit.

Do I need to separate the changes in the Tools folder and the hwdef file into two pull requests?

@Hwurzburg
Copy link
Collaborator

no, just two commits in this PR...I can do it for you tomorrow (I need to make a video on how to do this....many new contributors don't understand)...I will use your PR for the video how to...

@SULILG
Copy link
Contributor Author

SULILG commented Feb 4, 2025

no, just two commits in this PR...I can do it for you tomorrow (I need to make a video on how to do this....many new contributors don't understand)...I will use your PR for the video how to...

OK(After the video is made, please let me know the source of the video so I can learn from it)

@SULILG
Copy link
Contributor Author

SULILG commented Feb 5, 2025

I see, so only two submissions are needed, right?

@Hwurzburg
Copy link
Collaborator

correct ..here is the video I made https://www.youtube.com/watch?v=iMUWQUD_Rsg

@SULILG
Copy link
Contributor Author

SULILG commented Feb 6, 2025

@Hwurzburg What issues remain with this, and when can it be merged?

@Hwurzburg
Copy link
Collaborator

@andypiper please review before DECALL so this can be merged or modiffied

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants