-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the SULILGH7 flight controller board #29209
base: master
Are you sure you want to change the base?
Conversation
needs readme and images/pinout....ala https://github.com/ArduPilot/ardupilot/tree/master/libraries/AP_HAL_ChibiOS/hwdef/AET-H743-Basic |
I will add some images and descriptions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still suggest you reserve the board id by splitting out the board_types.txt into a new PR by itself
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I think @andyp1per would suggest trying to make at least four PWM outputs bi-directional DShot...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit list needs fixing to conform to our standards
should be two commits:There should be only the Tools:add SULIGH7-P1-P2 commit and a hwdef:add SULIGH7-P1-P2 commit. |
Do I need to separate the changes in the Tools folder and the hwdef file into two pull requests? |
no, just two commits in this PR...I can do it for you tomorrow (I need to make a video on how to do this....many new contributors don't understand)...I will use your PR for the video how to... |
OK(After the video is made, please let me know the source of the video so I can learn from it) |
I see, so only two submissions are needed, right? |
correct ..here is the video I made https://www.youtube.com/watch?v=iMUWQUD_Rsg |
@Hwurzburg What issues remain with this, and when can it be merged? |
@andypiper please review before DECALL so this can be merged or modiffied |
No description provided.