Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config utilities for processors and connectors #18

Merged
merged 10 commits into from
Feb 16, 2024
Merged

Conversation

lovromazgon
Copy link
Member

@lovromazgon lovromazgon commented Feb 14, 2024

Description

This PR creates package config and moves over code from the connector SDK regarding config parameters and validations. Some things are slightly refactored, but generally, the functionality stays the same.

This also adds a proto file for the parameter definitions. The idea behind this is that it will allow us to reuse the same code in the connector and processor SDK. Additionally, this package will allow us to reuse the same paramgen tool in connectors and processors.

Quick checks:

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

config/config.go Outdated Show resolved Hide resolved
Copy link
Contributor

@hariso hariso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@lovromazgon lovromazgon merged commit 3143d97 into main Feb 16, 2024
5 checks passed
@lovromazgon lovromazgon deleted the lovro/config branch February 16, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants