Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔊 Revert hooks and add missing URL context telemetry #3313

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

amortemousque
Copy link
Collaborator

@amortemousque amortemousque commented Feb 3, 2025

Motivation

Following #3289, we've started seeing the telemetry error
Cannot destructure property 'url' of 'o.find(...)' as it is undefined which comes from

This PR revert the hooks and adds telemetry to help diagnose the root cause.

Changes

  • Revert 07a99fa
  • Add missing URL telemetry

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@amortemousque amortemousque requested a review from a team as a code owner February 3, 2025 09:00
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 73.80952% with 11 lines in your changes missing coverage. Please review.

Project coverage is 93.49%. Comparing base (46cc11a) to head (b74939e).

Files with missing lines Patch % Lines
packages/rum-core/test/mockContexts.ts 20.00% 4 Missing ⚠️
packages/core/src/tools/valueHistory.ts 71.42% 2 Missing ⚠️
packages/rum-core/src/domain/assembly.ts 84.61% 2 Missing ⚠️
...ckages/rum-core/src/domain/contexts/urlContexts.ts 33.33% 2 Missing ⚠️
...ckages/rum-core/src/domain/contexts/viewHistory.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3313      +/-   ##
==========================================
- Coverage   93.58%   93.49%   -0.10%     
==========================================
  Files         291      290       -1     
  Lines        7691     7691              
  Branches     1751     1754       +3     
==========================================
- Hits         7198     7191       -7     
- Misses        493      500       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 146.77 KiB 146.77 KiB -4 B -0.00%
Logs 51.19 KiB 51.33 KiB 141 B +0.27%
Rum Slim 105.52 KiB 105.53 KiB 3 B 0.00%
Worker 24.50 KiB 24.50 KiB 0 B 0.00%
🚀 CPU Performance
Action Name Base Average Cpu Time (ms) Local Average Cpu Time (ms) 𝚫
addglobalcontext 0.002 0.002 -0.000
addaction 0.031 0.038 0.006
addtiming 0.006 0.009 0.003
adderror 0.028 0.036 0.008
startstopsessionreplayrecording 0.001 0.002 0.000
startview 0.007 0.010 0.003
logmessage 0.025 0.048 0.023
🧠 Memory Performance
Action Name Base Consumption Memory (bytes) Local Consumption Memory (bytes) 𝚫 (bytes)
addglobalcontext 28.15 KiB 27.76 KiB -401 B
addaction 57.12 KiB 56.67 KiB -455 B
addtiming 27.30 KiB 26.31 KiB -1015 B
adderror 62.00 KiB 60.61 KiB -1421 B
startstopsessionreplayrecording 25.50 KiB 26.76 KiB 1.26 KiB
startview 415.29 KiB 419.87 KiB 4.59 KiB
logmessage 60.20 KiB 61.30 KiB 1.10 KiB

🔗 RealWorld

Copy link
Contributor

@cy-moi cy-moi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙏

@amortemousque
Copy link
Collaborator Author

/to-staging

@dd-devflow
Copy link
Contributor

dd-devflow bot commented Feb 3, 2025

Devflow running: /to-staging

View all feedbacks in Devflow UI.


2025-02-03 16:24:31 UTC ℹ️ Branch Integration: starting soon, median merge time is 11m20s

Commit b74939e37a will soon be integrated into staging-06.


2025-02-03 16:38:05 UTC ℹ️ Branch Integration: This commit was successfully integrated

Commit b74939e37a has been merged into staging-06 in merge commit 6377a361a1.

Check out the triggered pipeline on Gitlab 🦊

If you need to revert this integration, you can use the following command: /code revert-integration -b staging-06

dd-mergequeue bot added a commit that referenced this pull request Feb 3, 2025
Integrated commit sha: b74939e

Co-authored-by: Aymeric Mortemousque <[email protected]>
@dd-devflow dd-devflow bot added the staging-06 label Feb 3, 2025
@amortemousque amortemousque merged commit 500bae2 into main Feb 4, 2025
20 checks passed
@amortemousque amortemousque deleted the aymeric/revert-hooks branch February 4, 2025 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants