Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mito wal proto #75

Merged
merged 14 commits into from
Aug 14, 2023
Merged

feat: mito wal proto #75

merged 14 commits into from
Aug 14, 2023

Conversation

evenyag
Copy link
Contributor

@evenyag evenyag commented Aug 2, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Wal entry proto for mito2. It stores rows directly.

Checklist

  • I have written the necessary comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@evenyag evenyag marked this pull request as ready for review August 14, 2023 08:13
@waynexia
Copy link
Member

IMO the WAL format should not be engine-specific

Copy link
Contributor

@v0y4g3r v0y4g3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@v0y4g3r v0y4g3r enabled auto-merge (squash) August 14, 2023 12:07
@v0y4g3r v0y4g3r merged commit a6897eb into main Aug 14, 2023
6 checks passed
@v0y4g3r v0y4g3r deleted the feat/mito-wal-proto branch August 14, 2023 12:08
@evenyag evenyag restored the feat/mito-wal-proto branch August 14, 2023 12:55
@waynexia waynexia deleted the feat/mito-wal-proto branch August 14, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants