Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merge DataLinks to MetcalfScoring class #249

Merged
merged 9 commits into from
Jun 10, 2024
Merged

merge DataLinks to MetcalfScoring class #249

merged 9 commits into from
Jun 10, 2024

Conversation

CunliangGeng
Copy link
Member

@CunliangGeng CunliangGeng commented May 31, 2024 •
edited
Loading

The role of class DataLinks is to calculate the presence and co-presence for given e.g. GCFs, spectra and strains. The presence matrix are required to compute the Metcalf scores.

This PR merge the role DataLinks to MetCalfScoring and utils to improve the clarity of codebase and to simplify the scoring process.

DataLinks also has a get_common_strains method that will be merged to ObjectLink class in next PR.

Major changes:

  • move functions of calculating presence to utils
  • merge function of calculating co-presence and raw score to MetcalfScoring
  • remove whole linking folder
  • remove deprecated and unused code

This was referenced May 31, 2024
Merged
Merged
Merged
@CunliangGeng Graphite App
Copy link
Member Author

CunliangGeng commented May 31, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CunliangGeng and the rest of your teammates on Graphite Graphite

@CunliangGeng CunliangGeng mentioned this pull request May 31, 2024
Merged
@CunliangGeng CunliangGeng self-assigned this May 31, 2024
@CunliangGeng CunliangGeng requested a review from gcroci2 May 31, 2024 08:58
@CunliangGeng CunliangGeng marked this pull request as ready for review May 31, 2024 08:58
This was referenced May 31, 2024
Merged
Closed
Merged
@CunliangGeng CunliangGeng force-pushed the merge_LinkFinder_to_MetcalfScoring branch from 3a92298 to 89aa35e Compare June 6, 2024 07:16
@CunliangGeng CunliangGeng force-pushed the merge_DataLinks_to_MetcalfScoring branch from 52960e6 to 7ef55a9 Compare June 6, 2024 07:16
@CunliangGeng CunliangGeng force-pushed the merge_LinkFinder_to_MetcalfScoring branch from 89aa35e to 145bd22 Compare June 6, 2024 07:20
@CunliangGeng CunliangGeng force-pushed the merge_DataLinks_to_MetcalfScoring branch 2 times, most recently from be49128 to abdc779 Compare June 6, 2024 07:24
@CunliangGeng CunliangGeng force-pushed the merge_LinkFinder_to_MetcalfScoring branch from 3974c23 to d13d883 Compare June 6, 2024 07:27
Base automatically changed from merge_LinkFinder_to_MetcalfScoring to dev June 6, 2024 07:29
@CunliangGeng CunliangGeng force-pushed the merge_DataLinks_to_MetcalfScoring branch from abdc779 to 1857d31 Compare June 6, 2024 13:49
@CunliangGeng CunliangGeng mentioned this pull request Jun 7, 2024
Merged
@CunliangGeng CunliangGeng mentioned this pull request Jun 7, 2024
Merged
@CunliangGeng Graphite App
Copy link
Member Author

CunliangGeng commented Jun 10, 2024 •
edited
Loading

Merge activity

@CunliangGeng CunliangGeng merged commit 5ba9e31 into dev Jun 10, 2024
3 of 4 checks passed
@CunliangGeng CunliangGeng deleted the merge_DataLinks_to_MetcalfScoring branch June 10, 2024 07:25
This was referenced Jun 10, 2024
Merged
Merged
Merged
Merged
Merged
@CunliangGeng CunliangGeng mentioned this pull request Jun 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gcroci2 gcroci2 gcroci2 approved these changes

Assignees

@CunliangGeng CunliangGeng

Labels
None yet
Projects
dev
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CunliangGeng @gcroci2