Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename molfam to mf to uniform the abbreviation for MolecularFamily #255

Merged
merged 1 commit into from
Jun 14, 2024
Merged

rename molfam to mf to uniform the abbreviation for MolecularFamily #255

merged 1 commit into from
Jun 14, 2024

Conversation

CunliangGeng
Copy link
Member

@CunliangGeng CunliangGeng commented Jun 10, 2024 •
edited
Loading

A simple PR: just renaming.

This was referenced Jun 10, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@CunliangGeng Graphite App
Copy link
Member Author

CunliangGeng commented Jun 10, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CunliangGeng and the rest of your teammates on Graphite Graphite

@CunliangGeng CunliangGeng mentioned this pull request Jun 10, 2024
Merged
@CunliangGeng CunliangGeng requested a review from gcroci2 June 10, 2024 15:51
@CunliangGeng CunliangGeng self-assigned this Jun 10, 2024
@CunliangGeng CunliangGeng marked this pull request as ready for review June 10, 2024 15:51
@CunliangGeng CunliangGeng mentioned this pull request Jun 11, 2024
Merged
@CunliangGeng CunliangGeng force-pushed the refactor_MetcalfScoring_methods branch from fceea81 to 51ad6f1 Compare June 13, 2024 11:23
@CunliangGeng CunliangGeng force-pushed the rename_molfam_to_mf branch from 450f78d to 916e1c3 Compare June 13, 2024 11:23
@CunliangGeng CunliangGeng force-pushed the rename_molfam_to_mf branch from 916e1c3 to 984d72b Compare June 14, 2024 08:42
@CunliangGeng CunliangGeng mentioned this pull request Jun 14, 2024
Merged
@CunliangGeng Graphite App
Copy link
Member Author

CunliangGeng commented Jun 14, 2024 •
edited
Loading

Merge activity

  • Jun 14, 7:27 AM EDT: @CunliangGeng started a stack merge that includes this pull request via Graphite.
  • Jun 14, 7:30 AM EDT: Graphite rebased this pull request as part of a merge.
  • Jun 14, 7:31 AM EDT: @CunliangGeng merged this pull request with Graphite.

Base automatically changed from refactor_MetcalfScoring_methods to dev June 14, 2024 11:28
@CunliangGeng CunliangGeng force-pushed the rename_molfam_to_mf branch from 984d72b to 3f997ff Compare June 14, 2024 11:29
@CunliangGeng CunliangGeng merged commit 06fe1f9 into dev Jun 14, 2024
2 of 3 checks passed
@CunliangGeng CunliangGeng deleted the rename_molfam_to_mf branch June 14, 2024 11:31
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
30.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

This was referenced Jun 17, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gcroci2 gcroci2 gcroci2 approved these changes

Assignees

@CunliangGeng CunliangGeng

Labels
None yet
Projects
dev
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CunliangGeng @gcroci2