-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge DataLinks get_common_strains
to ObjectLink
#250
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 31, 2024
Merged
This was referenced Jun 4, 2024
CunliangGeng
force-pushed
the
merge_DataLinks_to_MetcalfScoring
branch
from
June 6, 2024 07:16
52960e6
to
7ef55a9
Compare
CunliangGeng
force-pushed
the
merge_DataLinks_to_ObjectLink
branch
from
June 6, 2024 07:16
7f9f439
to
9711915
Compare
CunliangGeng
force-pushed
the
merge_DataLinks_to_MetcalfScoring
branch
from
June 6, 2024 07:21
7ef55a9
to
be49128
Compare
CunliangGeng
force-pushed
the
merge_DataLinks_to_ObjectLink
branch
from
June 6, 2024 07:21
9711915
to
8dade37
Compare
CunliangGeng
force-pushed
the
merge_DataLinks_to_MetcalfScoring
branch
from
June 6, 2024 07:24
be49128
to
abdc779
Compare
CunliangGeng
force-pushed
the
merge_DataLinks_to_ObjectLink
branch
from
June 6, 2024 07:24
8dade37
to
6674ba0
Compare
CunliangGeng
force-pushed
the
merge_DataLinks_to_MetcalfScoring
branch
from
June 6, 2024 13:49
abdc779
to
1857d31
Compare
CunliangGeng
force-pushed
the
merge_DataLinks_to_ObjectLink
branch
from
June 6, 2024 13:49
6674ba0
to
063ecdc
Compare
gcroci2
reviewed
Jun 7, 2024
gcroci2
approved these changes
Jun 7, 2024
Merge activity
|
now it's very easy to get common strains using the new `StrainCollection.intersection` method
CunliangGeng
force-pushed
the
merge_DataLinks_to_ObjectLink
branch
from
June 10, 2024 07:25
063ecdc
to
230162e
Compare
This was referenced Jun 10, 2024
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in last PR #249, the role of
DataLinks.get_common_strains
is merged toObjectLink
andStrainCollection
classes in this PR.Major changes
StrainCollection
to compute common strainscommon_strains
to a property inObjectLink
DataLinks.get_common_strains