Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADBMS Integration #138

Merged
merged 34 commits into from
Jan 25, 2025
Merged

ADBMS Integration #138

merged 34 commits into from
Jan 25, 2025

Conversation

Sabramz
Copy link
Contributor

@Sabramz Sabramz commented Nov 18, 2024

Changes

Low level drivers and some integration.

Test Cases

test bench

To Do

  • Voltage reading function is scalable
  • Therm reading function is scalable
  • Functions for reading every register
  • Voltage reading can be configured to be s, c, filtered, and avg
  • Function for setting GPIOs as outputs
  • New configuration function for new ICs
  • Change constants and algorithms for therms calculations

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please reach out to your Project Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No merge conflicts
  • All checks passing
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #133 (issue #)

@Sabramz Sabramz marked this pull request as draft November 18, 2024 03:07
@Sabramz Sabramz requested review from dyldonahue and jr1221 November 21, 2024 23:07
@Sabramz Sabramz self-assigned this Nov 21, 2024
int DataIdx;

for (DataIdx = 0; DataIdx < len; DataIdx++) {
__io_putchar( *ptr++ );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

messed up diff this stuff was changed on main??

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed this cuz printing was broken and i think it was cuz of the usart dma changes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm did u use \r? Also make sure to use ner serial or else it wont work.

Core/Src/segment.c Outdated Show resolved Hide resolved
Core/Src/segment.c Outdated Show resolved Hide resolved
Core/Src/segment.c Outdated Show resolved Hide resolved
Copy link
Contributor

@jr1221 jr1221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bunch of random stuff idk you prob know all of this anyway as this is WIP.

Only thing actually wierd is the whole wakeup IC stuff and how we now have a bunch of different types of wakeup functions all seeming to do similar stuff.

Core/Inc/bmsConfig.h Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
Core/Src/segment.c Outdated Show resolved Hide resolved
Core/Src/segment.c Outdated Show resolved Hide resolved
Core/Src/segment.c Outdated Show resolved Hide resolved
Core/Src/segment.c Outdated Show resolved Hide resolved
Core/Src/segment.c Outdated Show resolved Hide resolved
Core/Src/segment.c Outdated Show resolved Hide resolved
Core/Src/segment.c Outdated Show resolved Hide resolved
int DataIdx;

for (DataIdx = 0; DataIdx < len; DataIdx++) {
__io_putchar( *ptr++ );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm did u use \r? Also make sure to use ner serial or else it wont work.

@Sabramz Sabramz marked this pull request as ready for review December 25, 2024 23:44
@Sabramz Sabramz requested review from jr1221 and removed request for dyldonahue December 25, 2024 23:46
Copy link
Contributor

@jr1221 jr1221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more code hip hip hooray. really its impossible to figure out what is good and bad practice until the high level code gels better (we remove the years of therm and algo disable crap).

}
// TODO: Its kind of silly to just copy voltages like this. We should consolidate
// chip data and chips later, or design analyzer to read voltages from chips rather
// than chipdata
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree with both of the above TODOs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this didnt age well.

Core/Src/segment.c Outdated Show resolved Hide resolved
Core/Src/analyzer.c Outdated Show resolved Hide resolved
This was linked to issues Jan 18, 2025
@jr1221 jr1221 merged commit cd1e4d2 into develop Jan 25, 2025
2 checks passed
@jr1221 jr1221 deleted the 133-adbms-integration branch January 25, 2025 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Integrate ADBMS Drivers BMS Debug Mode Send all Cell Data over CAN
2 participants