-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADBMS Integration #138
ADBMS Integration #138
Conversation
…ed on pulling voltages
int DataIdx; | ||
|
||
for (DataIdx = 0; DataIdx < len; DataIdx++) { | ||
__io_putchar( *ptr++ ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
messed up diff this stuff was changed on main??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed this cuz printing was broken and i think it was cuz of the usart dma changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm did u use \r
? Also make sure to use ner serial
or else it wont work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bunch of random stuff idk you prob know all of this anyway as this is WIP.
Only thing actually wierd is the whole wakeup IC stuff and how we now have a bunch of different types of wakeup functions all seeming to do similar stuff.
int DataIdx; | ||
|
||
for (DataIdx = 0; DataIdx < len; DataIdx++) { | ||
__io_putchar( *ptr++ ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm did u use \r
? Also make sure to use ner serial
or else it wont work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
more code hip hip hooray. really its impossible to figure out what is good and bad practice until the high level code gels better (we remove the years of therm and algo disable crap).
Core/Src/segment.c
Outdated
} | ||
// TODO: Its kind of silly to just copy voltages like this. We should consolidate | ||
// chip data and chips later, or design analyzer to read voltages from chips rather | ||
// than chipdata |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree with both of the above TODOs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this didnt age well.
Changes
Low level drivers and some integration.
Test Cases
test bench
To Do
Checklist
It can be helpful to check the
Checks
andFiles changed
tabs.Please reach out to your Project Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
Closes #133 (issue #)