treewide: cleanup #178
Merged
treewide: cleanup #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
treewide: move from 'with lib' to 'inherit (lib) ...'
FrothyMarrow
force-pushed
the
assert-assertions
branch
from
5d282f4 to
4dc7576
Compare
horriblename
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a somewhat large PR, adding assertions into the build system (thanks to
@jordanisaacsfor that one) and reduces thelet inabuse in the core module by moving large functions into their respective libraries, making the core module less daunting to navigate (or contribute to). Another important highlight is the removal of mostwith lib;instances, thanks to @FrothyMarrowMost importantly, we can now use
mkRemovedOptionModuleandmkRenamedOptionModuleinside the module system, with the addition of assertions.