Add jekyll and ruby as docs-only dependency #14349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BetsyMcPhail
force-pushed
the
doc-only-setup
branch
from
977fa11 to
c78d1de
Compare
BetsyMcPhail
force-pushed
the
doc-only-setup
branch
from
c78d1de to
23c1c1f
Compare
BetsyMcPhail
commented
Dec 15, 2020
There was a problem hiding this comment.
@jamiesnape for review and +@rpoyner-tri for platform review please
Reviewable status: LGTM missing from assignees jamiesnape,rpoyner-tri(platform) (waiting on @jamiesnape and @rpoyner-tri)
jamiesnape
reviewed
Dec 15, 2020
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status: LGTM missing from assignee rpoyner-tri(platform) (waiting on @rpoyner-tri)
rpoyner-tri
reviewed
Dec 15, 2020
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! all discussions resolved, LGTM from assignees rpoyner-tri(platform),jamiesnape
jamiesnape
added
component: distribution
jamiesnape
added
component: continuous integration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working towards #13832
This change is