-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[workspace] Patch googlebenchmark to avoid shadow warnings #19796
[workspace] Patch googlebenchmark to avoid shadow warnings #19796
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+@RussTedrake for feature review, if you like?
Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee rpoyner-tri(platform)
systems/benchmarking/multilayer_perceptron_benchmark.cc
line 27 at r1 (raw file):
} void SetUp(benchmark::State& state) { // NOLINT(runtime/references)
btw -- apparently switching to BenchmarkStateRef is another approach (used above) to trick the linter? Perhaps we should make them consistent?
This allows us to remove copy-pasta in every benchmark we write.
c01a517
to
bf56cd0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @RussTedrake; I'll count you as platform review. I'd still like Rico to feature-review as our subject matter expert.
Reviewable status: LGTM missing from assignee rpoyner-tri(platform)
systems/benchmarking/multilayer_perceptron_benchmark.cc
line 27 at r1 (raw file):
Previously, RussTedrake (Russ Tedrake) wrote…
btw -- apparently switching to BenchmarkStateRef is another approach (used above) to trick the linter? Perhaps we should make them consistent?
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: LGTM missing from assignee rpoyner-tri(platform)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 7 of 8 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all discussions resolved, LGTM from assignees rpoyner-tri(platform),RussTedrake(platform)
This allows us to remove copy-pasta in every benchmark we write.
+@rpoyner-tri for feature review, please.
\CC @RussTedrake whichever #19771 or this merges first, the other one should rebase to delete the pasta in the new benchmark, too.
This change is