Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't install drake_models from manipulation_station #19836

Merged

Conversation

RussTedrake
Copy link
Contributor

@RussTedrake RussTedrake commented Jul 23, 2023

Follow-up to #19771. Related to #19822.

The workflow for drake_models has changed. I should not have installed them.

+@rpoyner-tri for both reviews, please.
Thanks @adeeb10abbas for the help!

Relevant slack thread: https://drakedevelopers.slack.com/archives/C2PMBJVAN/p1690124580155169


This change is Reviewable

Follow-up to RobotLocomotion#19771. Related to RobotLocomotion#19822.

The workflow for drake_models has changed. I should not have installed them.
@RussTedrake RussTedrake added status: single reviewer ok https://drake.mit.edu/reviewable.html release notes: none This pull request should not be mentioned in the release notes labels Jul 23, 2023
Copy link
Contributor

@rpoyner-tri rpoyner-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignee rpoyner-tri(platform)

@rpoyner-tri rpoyner-tri merged commit c1474e6 into RobotLocomotion:master Jul 24, 2023
@jwnimmer-tri
Copy link
Collaborator

jwnimmer-tri commented Jul 27, 2023

FYI I'll see what I can do about having the build fail-fast with a good diagnostic, in case this happens again.

Edit: => #19861

@RussTedrake RussTedrake deleted the dont_install_drake_models branch August 7, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes: none This pull request should not be mentioned in the release notes status: single reviewer ok https://drake.mit.edu/reviewable.html
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants