[examples] Move punyo files into drake_models #21231
Conversation
jwnimmer-tri
added
the
release notes: fix
|
+@DamrongGuoy for feature review, please. |
jwnimmer-tri
force-pushed
the
wsg_50_hydro_bubble
branch
from
a8e2f82 to
669f15f
Compare
There was a problem hiding this comment.
CC: @joemasterjohn
Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: 1 unresolved discussion, needs platform reviewer assigned, needs at least two assigned reviewers
examples/hydroelastic/spatula_slip_control/BUILD.bazel line 26 at r1 (raw file):
data = [ ":models", "//manipulation/models/wsg_50_description:models",
BTW, we don't need this line anymore.
jwnimmer-tri
force-pushed
the
wsg_50_hydro_bubble
branch
from
669f15f to
9f88e34
Compare
There was a problem hiding this comment.
+@rpoyner-tri for platform review per schedule (tomorrow), please.
Reviewable status: LGTM missing from assignee rpoyner-tri(platform)
There was a problem hiding this comment.
-@rpoyner-tri +@ggould-tri for platform review per schedule (tomorrow), please.
Reviewable status: LGTM missing from assignee ggould-tri(platform)
There was a problem hiding this comment.
Reviewed 8 of 9 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all discussions resolved, LGTM from assignees ggould-tri(platform),DamrongGuoy
There was a problem hiding this comment.
Reviewable status: 1 unresolved discussion
tools/workspace/drake_models/repository.bzl line 9 at r2 (raw file):
name = name, repository = "RobotLocomotion/models", commit = "b2f1a5de046d0b0d27dd5b8f09020addc9a19280",
Working
Needs real sha
jwnimmer-tri
force-pushed
the
wsg_50_hydro_bubble
branch
from
9f88e34 to
20e0a99
Compare
There was a problem hiding this comment.
Reviewable status:
tools/workspace/drake_models/repository.bzl line 9 at r2 (raw file):
Previously, jwnimmer-tri (Jeremy Nimmer) wrote…
Working
Needs real sha
Done
Ditch the "models" subdir (moving spatula up one level). Remove unwanted install rules for these files. Fix image naming for consistency. [workspace] Upgrade drake_models to latest commit.
jwnimmer-tri
force-pushed
the
wsg_50_hydro_bubble
branch
from
20e0a99 to
a1e9f43
Compare
Ditch the "models" subdir (moving spatula up one level). Remove unwanted install rules for these files. Fix image naming for consistency. [workspace] Upgrade drake_models to latest commit.
Ditch the "models" subdir (moving spatula up one level).
Remove unwanted install rules for these files.
Fix image naming for consistency.
[workspace] Upgrade drake_models to latest commit.
Twin PR: RobotLocomotion/models#53
Towards #13942.
This change is