Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[examples] Copy quadrotor.urdf to drake_models #21238

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

jwnimmer-tri
Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri commented Apr 2, 2024

We'll remove the file from Drake after the next release, to provide a smoother glide path for underactuated.csail.mit.edu which is being taught this spring.


Even though this model is "deprecated", I'm not going to mark it as such in that section of the release notes. Instead, it'll just be part of the broader "model files move" announcement.

Towards #13942.

Twin PR: RobotLocomotion/models#55


This change is Reviewable

@jwnimmer-tri jwnimmer-tri added priority: low status: single reviewer ok https://drake.mit.edu/reviewable.html release notes: fix This pull request contains fixes (no new features) labels Apr 2, 2024
Copy link
Collaborator Author

@jwnimmer-tri jwnimmer-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@ggould-tri for both reviews per schedule, please.

\CC @RussTedrake FYI

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee ggould-tri(platform)


tools/workspace/drake_models/repository.bzl line 9 at r1 (raw file):

        name = name,
        repository = "RobotLocomotion/models",
        commit = "54684a01dad22d42a24401c7666dcd3bb1739499",

Working

Needs real git sha from master.

Copy link
Contributor

@ggould-tri ggould-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: 1 unresolved discussion

We'll remove the file from Drake after the next release, to provide a
smoother glide path for underactuated.csail.mit.edu.

[workspace] Upgrade drake_models to latest commit
Copy link
Collaborator Author

@jwnimmer-tri jwnimmer-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignee ggould-tri(platform)


tools/workspace/drake_models/repository.bzl line 9 at r1 (raw file):

Previously, jwnimmer-tri (Jeremy Nimmer) wrote…

Working

Needs real git sha from master.

Done

@jwnimmer-tri jwnimmer-tri merged commit 71310ac into RobotLocomotion:master Apr 2, 2024
8 of 9 checks passed
@jwnimmer-tri jwnimmer-tri deleted the skydio branch April 2, 2024 18:21
RussTedrake pushed a commit to RussTedrake/drake that referenced this pull request Dec 15, 2024
We'll remove the file from Drake after the next release, to provide a
smoother glide path for underactuated.csail.mit.edu.

[workspace] Upgrade drake_models to latest commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low release notes: fix This pull request contains fixes (no new features) status: single reviewer ok https://drake.mit.edu/reviewable.html
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants