-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[examples] Copy quadrotor.urdf to drake_models #21238
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+@ggould-tri for both reviews per schedule, please.
\CC @RussTedrake FYI
Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee ggould-tri(platform)
tools/workspace/drake_models/repository.bzl
line 9 at r1 (raw file):
name = name, repository = "RobotLocomotion/models", commit = "54684a01dad22d42a24401c7666dcd3bb1739499",
Working
Needs real git sha from master.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: 1 unresolved discussion
We'll remove the file from Drake after the next release, to provide a smoother glide path for underactuated.csail.mit.edu. [workspace] Upgrade drake_models to latest commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all discussions resolved, LGTM from assignee ggould-tri(platform)
tools/workspace/drake_models/repository.bzl
line 9 at r1 (raw file):
Previously, jwnimmer-tri (Jeremy Nimmer) wrote…
Working
Needs real git sha from master.
Done
We'll remove the file from Drake after the next release, to provide a smoother glide path for underactuated.csail.mit.edu. [workspace] Upgrade drake_models to latest commit
We'll remove the file from Drake after the next release, to provide a smoother glide path for
underactuated.csail.mit.edu
which is being taught this spring.Even though this model is "deprecated", I'm not going to mark it as such in that section of the release notes. Instead, it'll just be part of the broader "model files move" announcement.
Towards #13942.
Twin PR: RobotLocomotion/models#55
This change is