Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of fmt::joint requires fmt/ranges.h #22064

Merged

Conversation

SeanCurtis-TRI
Copy link
Contributor

@SeanCurtis-TRI SeanCurtis-TRI commented Oct 22, 2024

Hotfix for #22043.


This change is Reviewable

@SeanCurtis-TRI
Copy link
Contributor Author

@drake-jenkins-bot mac-arm-sonoma-unprovisioned-clang-cmake-experimental-everything-release please

@SeanCurtis-TRI SeanCurtis-TRI added release notes: none This pull request should not be mentioned in the release notes status: single reviewer ok https://drake.mit.edu/reviewable.html labels Oct 22, 2024
Copy link
Contributor Author

@SeanCurtis-TRI SeanCurtis-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+(release notes: none)
+(status: single reviewer ok)
+@jwnimmer-tri for both reviews, please.

Reviewable status: LGTM missing from assignee jwnimmer-tri(platform)

Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: thanks!

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignee jwnimmer-tri(platform)

@jwnimmer-tri
Copy link
Collaborator

The macOS CI is down, so I'll just merge this and hope for the best.

@jwnimmer-tri jwnimmer-tri merged commit ac4d16f into RobotLocomotion:master Oct 22, 2024
7 of 10 checks passed
@SeanCurtis-TRI SeanCurtis-TRI deleted the PR_22043_quick_fix branch October 22, 2024 14:48
RussTedrake pushed a commit to RussTedrake/drake that referenced this pull request Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: emergency release notes: none This pull request should not be mentioned in the release notes status: single reviewer ok https://drake.mit.edu/reviewable.html
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants