[tri_homecart] Move related Drake files into here #31
Conversation
The files were copied as of Drake commit 098ed592. Add the missing LICENSE text (for non-third-party files). Adopt the new convention of `assets` for meshes, images, etc. Co-authored-by: Rick Poyner (rico) <[email protected]> Co-authored-by: Russ Tedrake <[email protected]> Co-authored-by: William Allen <[email protected]>
jwnimmer-tri
force-pushed
the
mv-tri_homecart
branch
from
b9d482b to
92ed924
Compare
|
+@zachfang for feature review, please. |
There was a problem hiding this comment.
Reviewed 25 of 25 files at r1.
Reviewable status: 2 unresolved discussions, platform LGTM missing (waiting on @jwnimmer-tri)
tri_homecart/homecart_bimanual.urdf line 3 at r1 (raw file):
<?xml version="1.0" ?> <!-- =================================================================================== --> <!-- | This document was autogenerated by xacro from manipulation/models/tri_homecart/homecart_bimanual.urdf.xacro | -->
BTW. The path is "inaccurate:" now after the move. It's an autogenerated file, so not sure if it's worth fixing.
Code quote:
manipulation/models/tri_homecart/homecart_bimanual.urdf.xacrotri_homecart/homecart_cutting_board.sdf line 3 at r1 (raw file):
<?xml version="1.0" ?> <!-- =================================================================================== --> <!-- | This document was autogenerated by xacro from manipulation/models/tri_homecart/homecart_cutting_board.sdf.xacro | -->
BTW. Ditto.
Code quote:
manipulation/models/tri_homecart/homecart_cutting_board.sdf.xacro
There was a problem hiding this comment.
+@sherm1 for platform review per schedule, please.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee sherm1, platform LGTM missing (waiting on @sherm1 and @zachfang)
tri_homecart/homecart_bimanual.urdf line 3 at r1 (raw file):
Previously, zachfang wrote…
BTW. The path is "inaccurate:" now after the move. It's an autogenerated file, so not sure if it's worth fixing.
Yeah. I had the choice of keeping the same content as the Drake git hash cited in the commit message, or adjusting the file(s) by running Xacro again. Given #32 isn't ready yet, I decided not to try running it again since I would probably screw it up. When we do #32, the files will re-sync.
There was a problem hiding this comment.
Platform
Reviewed 25 of 25 files at r1, all commit messages.
Reviewable status: 1 unresolved discussion, platform LGTM from [sherm1] (waiting on @jwnimmer-tri)
tri_homecart/LICENSE line 1 at r1 (raw file):
Copyright 2022 Toyota Research Institute
BTW customary to update the year for new license installations
There was a problem hiding this comment.
Reviewable status:
complete! all discussions resolved, platform LGTM from [sherm1] (waiting on @jwnimmer-tri)
tri_homecart/LICENSE line 1 at r1 (raw file):
Previously, sherm1 (Michael Sherman) wrote…
BTW customary to update the year for new license installations
The files were authored in 2022. I am not changing the files here, only moving them.
The files were copied as of Drake commit
098ed592.Add the missing
LICENSEtext (for non-third-party files).Adopt the new convention of
assetsfor meshes, images, etc.See #32 for some looming tech debt.
Drake PR: RobotLocomotion/drake#21004
This change is