Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tri_homecart] Move to drake_models package #21004

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

jwnimmer-tri
Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri commented Feb 21, 2024

For example, users should now load

package://drake_models/tri_homecart/homecart.dmd.yaml

instead of

package://drake/manipulation/models/tri_homecart/homecart.dmd.yaml


Towards #20932 and #13942.

Models PR: RobotLocomotion/models#31

Per https://drake.mit.edu/stable.html#model-files our model data is not Stable API so this is regular release notes, not "breaking change".


This change is Reviewable

@jwnimmer-tri jwnimmer-tri added the release notes: fix This pull request contains fixes (no new features) label Feb 21, 2024
@jwnimmer-tri jwnimmer-tri changed the title [tri_homecart] Move to drake_models pacakge [tri_homecart] Move to drake_models package Feb 21, 2024
@jwnimmer-tri jwnimmer-tri force-pushed the mv-tri_homecart branch 2 times, most recently from 9610c5f to 82eb937 Compare February 21, 2024 03:08
@jwnimmer-tri jwnimmer-tri marked this pull request as ready for review February 21, 2024 03:09
@jwnimmer-tri jwnimmer-tri force-pushed the mv-tri_homecart branch 2 times, most recently from 85804c4 to 2e20cef Compare February 21, 2024 04:17
@jwnimmer-tri
Copy link
Collaborator Author

+@zachfang for feature review, please.

Copy link
Contributor

@zachfang zachfang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 17 of 18 files at r1, 1 of 1 files at r2.
Reviewable status: 2 unresolved discussions, needs platform reviewer assigned, needs at least two assigned reviewers


BUILD.bazel line 69 at r2 (raw file):

        "//manipulation/models/ycb:models",
        "//multibody/benchmarks/acrobot:models",
        "@drake_models",

BTW. Just to understand the strategy better, is our plan to lump all the model files into one @drake_models even though a target only needs a subset of the models?

Code quote:

"@drake_models"

tools/workspace/drake_models/repository.bzl line 9 at r2 (raw file):

        name = name,
        repository = "RobotLocomotion/models",
        commit = "92ed9246562caf6a77a4376b74b41eb777b319c8",

I assume the commit needs updating after model#31 is merged. Put a comment to gate that.

Code quote:

92ed9246562caf6a77a4376b74b41eb777b319c8

Copy link
Collaborator Author

@jwnimmer-tri jwnimmer-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@sherm1 for platform review per schedule, please.

Reviewable status: 2 unresolved discussions, LGTM missing from assignee sherm1(platform)


BUILD.bazel line 69 at r2 (raw file):

Previously, zachfang wrote…

BTW. Just to understand the strategy better, is our plan to lump all the model files into one @drake_models even though a target only needs a subset of the models?

Well, this is Drake's top-level :all_models target, so it really does want everything.

For the benchmarking program change down below, we could imagine writing down just the subset of of the models that it cares about, but I don't think it would help very much. Our developers do not frequently re-pin the models repository.

Copy link
Member

@sherm1 sherm1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Platform :lgtm:
Do these name changes require an Anzu update to match?

Reviewed 17 of 18 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: 1 unresolved discussion

Copy link
Collaborator Author

@jwnimmer-tri jwnimmer-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 unresolved discussion


tools/workspace/drake_models/repository.bzl line 9 at r2 (raw file):

Previously, zachfang wrote…

I assume the commit needs updating after model#31 is merged. Put a comment to gate that.

Done.

Copy link
Contributor

@zachfang zachfang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3.
Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignees sherm1(platform),zachfang

Copy link
Collaborator Author

@jwnimmer-tri jwnimmer-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these name changes require an Anzu update to match?

Nope, I checked and neither Anzu, nor Underactuated, nor Manipulation use this model. The only place it seems to be used is the planning benchmark.

Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignees sherm1(platform),zachfang

Update drake_models to latest commit.

For example, users should now load
  package://drake_models/tri_homecart/homecart.dmd.yaml
instead of
  package://drake/manipulation/models/tri_homecart/homecart.dmd.yaml
@jwnimmer-tri jwnimmer-tri merged commit 0bde095 into RobotLocomotion:master Feb 22, 2024
9 of 10 checks passed
@jwnimmer-tri jwnimmer-tri deleted the mv-tri_homecart branch February 22, 2024 19:21
jwnimmer-tri added a commit to jwnimmer-tri/drake that referenced this pull request Apr 1, 2024
Update drake_models to latest commit.

For example, users should now load
  package://drake_models/tri_homecart/homecart.dmd.yaml
instead of
  package://drake/manipulation/models/tri_homecart/homecart.dmd.yaml
RussTedrake pushed a commit to RussTedrake/drake that referenced this pull request Dec 15, 2024
Update drake_models to latest commit.

For example, users should now load
  package://drake_models/tri_homecart/homecart.dmd.yaml
instead of
  package://drake/manipulation/models/tri_homecart/homecart.dmd.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: medium release notes: fix This pull request contains fixes (no new features)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants