Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SHS-5996/SHS-5997: WYSIWYG link styles with arrow or external-link show green icon instead of matching the colour palette / WYSIWYG link style "External Link" does not show external icon #1703

Open
wants to merge 2 commits into
base: 11.6.1-release
Choose a base branch
from
Open

SHS-5996/SHS-5997: WYSIWYG link styles with arrow or external-link show green icon instead of matching the colour palette / WYSIWYG link style "External Link" does not show external icon #1703

wants to merge 2 commits into from
+13 −2

Conversation

mariannuar
Copy link
Collaborator

@mariannuar mariannuar commented Dec 19, 2024 •
edited
Loading

READY FOR REVIEW

Summary

  • WYSIWYG link styles with arrow or external-link icon color matches the colour palette
  • WYSIWYG link style "External Link" shows external icon

Need Review By (Date)

12/20

Urgency

medium

Steps to Test

  1. Go to Colorful and Traditional
  2. Or create a flexible page and add a WYSIWYG block with a "More link" style and a "External link" sty;e
  3. Confirm the icon color matches the default colour palette (cardinal) for the "More link"
  4. Confirm the style matches as expected in the "External link" style preview

PR Checklist

@ahughes3 ahughes3 temporarily deployed to Tugboat December 19, 2024 00:59 Destroyed
@mariannuar mariannuar self-assigned this Dec 19, 2024
@mariannuar mariannuar requested a review from cienvaras December 19, 2024 01:21
cienvaras
cienvaras requested changes Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@cienvaras cienvaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mariannuar Looks good, just a minor change needed.

docroot/themes/humsci/humsci_basic/src/scss/utilities/_wysiwyg-text-area.scss
Comment on lines +343 to +351
.ck-style-grid__button & {
&::after {
width: 18px;
height: 11px;
margin-bottom: 0;
background-size: 11px;
padding-left: 0;
}
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is used for the styles for the WYSIWYG text blocks in the FE theme. The styles you're adding are only for the CKEditor UI, so please move them in the admin theme CSS (docroot/themes/humsci/su_humsci_gin_admin/dist/su_humsci_gin_admin.css).

Also, please add a comment to explain why are you resizing the icon.

@ahughes3
Copy link
Collaborator

Tugboat has finished building the preview for this pull request!

Links:

Dashboard:

Visual Diffs:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cienvaras cienvaras cienvaras requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@mariannuar mariannuar

Labels
Needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mariannuar @ahughes3 @cienvaras