Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHS-5996/SHS-5997: WYSIWYG link styles with arrow or external-link show green icon instead of matching the colour palette / WYSIWYG link style "External Link" does not show external icon #1703

Open
wants to merge 2 commits into
base: 11.6.1-release
Choose a base branch
from
Open

SHS-5996/SHS-5997: WYSIWYG link styles with arrow or external-link show green icon instead of matching the colour palette / WYSIWYG link style "External Link" does not show external icon #1703

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b7fa7e
fix(shs-5996-shs-5997): wysiwyg more link and external link styles
Dec 19, 2024
846d8d7
Merge branch '11.6.1-release' of github.com:SU-HSDO/suhumsci into shs…
cienvaras Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docroot/themes/humsci/humsci_basic/src/scss/tools/_mixins.icons.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
background-image: svg(hc-get-icons($icon, $icon-color));

} @else {
$icon-color: map-get(map-get($hc-colorful-pairings, 'ocean'), $color);
$icon-color: map-get(map-get($hc-colorful-pairings, 'cardinal'), $color);
background-image: svg(hc-get-icons($icon, $icon-color));

.hc-pairing-ocean & {
Expand Down
13 changes: 12 additions & 1 deletion docroot/themes/humsci/humsci_basic/src/scss/utilities/_wysiwyg-text-area.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,8 @@ blockquote:nth-child(n) {
}

a[href*="//"].hs-external-link,
.hs-external-link a[href*="//"]
.hs-external-link a[href*="//"],
.ck-content a.hs-external-link
{
@include hb-link--inline;
@include hb-external-link-icon;
Expand Down Expand Up @@ -338,6 +339,16 @@ a[href*="//"].hs-external-link,
}
}
}

.ck-style-grid__button & {
&::after {
width: 18px;
height: 11px;
margin-bottom: 0;
background-size: 11px;
padding-left: 0;
}
}
Comment on lines +343 to +351
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is used for the styles for the WYSIWYG text blocks in the FE theme. The styles you're adding are only for the CKEditor UI, so please move them in the admin theme CSS (docroot/themes/humsci/su_humsci_gin_admin/dist/su_humsci_gin_admin.css).

Also, please add a comment to explain why are you resizing the icon.

}

a.hs-private-link,
Expand Down
Loading