Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHS-5996/SHS-5997: WYSIWYG link styles with arrow or external-link show green icon instead of matching the colour palette / WYSIWYG link style "External Link" does not show external icon #1703

Open
wants to merge 8 commits into
base: 11.6.1-release
Choose a base branch
from
Next Next commit
fix(shs-5996-shs-5997): wysiwyg more link and external link styles
Mari Nez committed Dec 19, 2024
commit 4b7fa7e990965876a1fb1fec4eb01e91335d04fb
Original file line number Diff line number Diff line change
@@ -6,7 +6,7 @@
background-image: svg(hc-get-icons($icon, $icon-color));

} @else {
$icon-color: map-get(map-get($hc-colorful-pairings, 'ocean'), $color);
$icon-color: map-get(map-get($hc-colorful-pairings, 'cardinal'), $color);
background-image: svg(hc-get-icons($icon, $icon-color));

.hc-pairing-ocean & {
Original file line number Diff line number Diff line change
@@ -308,7 +308,8 @@ blockquote:nth-child(n) {
}

a[href*="//"].hs-external-link,
.hs-external-link a[href*="//"]
.hs-external-link a[href*="//"],
.ck-content a.hs-external-link
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I missed this one on the previous release, but this is also specific to the editor and shouldn't be in the FE styles. Can you please move this to docroot/themes/humsci/humsci_basic/src/scss/admin/_wysiwyg-editor.scss?

{
@include hb-link--inline;
@include hb-external-link-icon;
@@ -338,6 +339,16 @@ a[href*="//"].hs-external-link,
}
}
}

.ck-style-grid__button & {
&::after {
width: 18px;
height: 11px;
margin-bottom: 0;
background-size: 11px;
padding-left: 0;
}
}
mariannuar marked this conversation as resolved.
Show resolved Hide resolved
}

a.hs-private-link,