Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated Netbox SNMP properties #2754

Conversation

lunkwill42
Copy link
Member

There is no code left referencing these deprecated properties, they can safely be removed now.

There is no code left referencing these deprecated properties, they
can safely be removed now.
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (48b4393) 55.57% compared to head (d016b28) 55.57%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2754   +/-   ##
=======================================
  Coverage   55.57%   55.57%           
=======================================
  Files         567      567           
  Lines       41247    41222   -25     
=======================================
- Hits        22922    22909   -13     
+ Misses      18325    18313   -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Test results

     12 files       12 suites   11m 19s ⏱️
3 267 tests 3 267 ✔️ 0 💤 0
9 276 runs  9 276 ✔️ 0 💤 0

Results for commit d016b28.

@lunkwill42 lunkwill42 merged commit 3b4ec87 into Uninett:master Nov 21, 2023
13 checks passed
@lunkwill42 lunkwill42 deleted the clean/remove-deprecated-netbox-properties branch November 21, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants