Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not publish test reports on pushes to master #2914

Conversation

johannaengland
Copy link
Contributor

@johannaengland johannaengland commented May 15, 2024

Closes #2862.

This will only publish test results if the branch the workflow "Build NAV and run full test suite" is running on is not master.

Reference: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#onworkflow_runbranchesbranches-ignore

Does this workflow usually fail on pushes to other branches? Because the commit 3e434bc#diff-208a7f7ef0a1174d68708f24502994bd2a136c75128806eb0cf63c0a70679321 does not do anything about this as far as I understand it.

See https://github.com/EnricoMi/publish-unit-test-result-action/releases/tag/v2.15.0 for the change in the publish Github action.

@johannaengland johannaengland self-assigned this May 15, 2024
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.23%. Comparing base (a52309e) to head (d46190b).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2914   +/-   ##
=======================================
  Coverage   60.23%   60.23%           
=======================================
  Files         602      602           
  Lines       44050    44050           
=======================================
  Hits        26534    26534           
  Misses      17516    17516           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented May 15, 2024

Test results

     12 files       12 suites   11m 29s ⏱️
3 323 tests 3 323 ✔️ 0 💤 0
9 444 runs  9 444 ✔️ 0 💤 0

Results for commit d46190b.

♻️ This comment has been updated with latest results.

@johannaengland
Copy link
Contributor Author

Test results

     12 files       12 suites   11m 40s ⏱️ 3 320 tests 3 320 ✔️ 0 💤 0 9 435 runs  9 435 ✔️ 0 💤 0

Results for commit 476c611.

So we see here that it definitely runs in pull requests. Now we just have to see that is does not run when pushing directly to master.

@johannaengland johannaengland force-pushed the workflows/do-not-publish-test-results-on-master branch from 1ae3623 to 1696340 Compare May 15, 2024 09:30
@johannaengland johannaengland force-pushed the workflows/do-not-publish-test-results-on-master branch from 1696340 to d46190b Compare May 15, 2024 11:58
@johannaengland johannaengland merged commit 30ba222 into Uninett:master May 15, 2024
11 of 12 checks passed
@johannaengland johannaengland deleted the workflows/do-not-publish-test-results-on-master branch May 15, 2024 12:15
lunkwill42 added a commit that referenced this pull request May 16, 2024
…-publish-test-results-on-master"

This reverts commit 30ba222, reversing
changes made to a52309e.

It had an obvious detrimental effect on our workflows, as evidenced by
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reinstate rule that avoids posting test reports on non-PR pushes
2 participants