-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not publish test reports on pushes to master #2914
Merged
johannaengland
merged 2 commits into
Uninett:master
from
johannaengland:workflows/do-not-publish-test-results-on-master
May 15, 2024
Merged
Do not publish test reports on pushes to master #2914
johannaengland
merged 2 commits into
Uninett:master
from
johannaengland:workflows/do-not-publish-test-results-on-master
May 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2914 +/- ##
=======================================
Coverage 60.23% 60.23%
=======================================
Files 602 602
Lines 44050 44050
=======================================
Hits 26534 26534
Misses 17516 17516 ☔ View full report in Codecov by Sentry. |
johannaengland
force-pushed
the
workflows/do-not-publish-test-results-on-master
branch
from
May 15, 2024 09:30
1ae3623
to
1696340
Compare
lunkwill42
approved these changes
May 15, 2024
johannaengland
force-pushed
the
workflows/do-not-publish-test-results-on-master
branch
from
May 15, 2024 11:58
1696340
to
d46190b
Compare
johannaengland
deleted the
workflows/do-not-publish-test-results-on-master
branch
May 15, 2024 12:15
This was referenced May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2862.
This will only publish test results if the branch the workflow "Build NAV and run full test suite" is running on is not master.
Reference: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#onworkflow_runbranchesbranches-ignore
Does this workflow usually fail on pushes to other branches? Because the commit 3e434bc#diff-208a7f7ef0a1174d68708f24502994bd2a136c75128806eb0cf63c0a70679321 does not do anything about this as far as I understand it.
See https://github.com/EnricoMi/publish-unit-test-result-action/releases/tag/v2.15.0 for the change in the publish Github action.