Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused test variables #3033

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

johannaengland
Copy link
Contributor

Just like #3028 and #3029 another part in adding F841 to ruff.

Copy link

sonarcloud bot commented Sep 25, 2024

Copy link

github-actions bot commented Sep 25, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 992 0 13.02s
✅ PYTHON ruff 988 0 0.1s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Copy link

github-actions bot commented Sep 25, 2024

Test results

    9 files      9 suites   8m 2s ⏱️
2 143 tests 2 143 ✅ 0 💤 0 ❌
4 025 runs  4 025 ✅ 0 💤 0 ❌

Results for commit fddb547.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.40%. Comparing base (480b586) to head (fddb547).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3033   +/-   ##
=======================================
  Coverage   60.40%   60.40%           
=======================================
  Files         605      605           
  Lines       43685    43685           
  Branches       48       48           
=======================================
  Hits        26388    26388           
  Misses      17285    17285           
  Partials       12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@johannaengland johannaengland force-pushed the cleanup/remove-unused-test-variables branch from 3650463 to 3849f10 Compare November 15, 2024 11:19
@johannaengland johannaengland force-pushed the cleanup/remove-unused-test-variables branch from 3849f10 to fddb547 Compare November 25, 2024 11:56
Copy link

sonarcloud bot commented Nov 25, 2024

@johannaengland johannaengland merged commit 8b0e5bd into master Nov 25, 2024
13 of 14 checks passed
@johannaengland johannaengland deleted the cleanup/remove-unused-test-variables branch November 25, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants