chore: test project updates 2023-Q3 #2679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated several samples to use UnityTransport as opposed to UNet. Limited number of objects spawned, adjusted the ray cast line renderer, updated the physics player to have a ray pointing towards its forward (to know the direction you are going) in physics example. Adjusted the connect mode buttons so they will automatically re-appear when you disconnect. Updated several projects to have their own network prefab list. .
ShadauxCat
reviewed
Aug 28, 2023
| m_AuthenticationButtons.SetActive(NetworkManager.Singleton && !NetworkManager.Singleton.IsListening && !AuthenticationService.Instance.IsSignedIn); | ||
| if (m_ConnectionModeButtons != null) | ||
| { | ||
| m_ConnectionModeButtons.SetActive(false || AuthenticationService.Instance.IsSignedIn); |
There was a problem hiding this comment.
...ok, I know this isn't your code, but isn't false || IsSignedIn literally identical to just IsSignedIn? false || false => false, false || true => true...
This seems... really silly.
There was a problem hiding this comment.
Yeah... I wasn't sure what that was all about...
It really should just be checking AuthenticationService.Instance.IsSignedIn...
ShadauxCat
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just contains several clean up related fixes for NGO's test project samples and manual tests.
Testing and Documentation