Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose diagnostic error codes #225

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Revert shorting the wait after clearing PSTOP

0f2d473
Select commit
Loading
Failed to load commit list.
Open

Expose diagnostic error codes #225

Revert shorting the wait after clearing PSTOP
0f2d473
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jan 20, 2025 in 0s

71.11% (-0.60%) compared to 2c12bee

View this Pull Request on Codecov

71.11% (-0.60%) compared to 2c12bee

Details

Codecov Report

Attention: Patch coverage is 75.23810% with 26 lines in your changes missing coverage. Please review.

Project coverage is 71.11%. Comparing base (2c12bee) to head (0f2d473).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
...clude/ur_client_library/primary/primary_consumer.h 70.73% 11 Missing and 1 partial ⚠️
include/ur_client_library/comm/pipeline.h 16.66% 10 Missing ⚠️
src/primary/primary_client.cpp 86.66% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #225      +/-   ##
==========================================
- Coverage   71.71%   71.11%   -0.60%     
==========================================
  Files          71       75       +4     
  Lines        2786     2884      +98     
  Branches      353      363      +10     
==========================================
+ Hits         1998     2051      +53     
- Misses        596      635      +39     
- Partials      192      198       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.