Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

Set Metrics configuration using ldlfags #1088

Merged
merged 2 commits into from
Oct 14, 2022
Merged

Set Metrics configuration using ldlfags #1088

merged 2 commits into from
Oct 14, 2022

Conversation

meain
Copy link
Member

@meain meain commented Oct 7, 2022 •
edited
Loading

Description

This sets up the metrics configs using ldflags. Keeping it in draft as I wanted to wait till #1052 is merged as that will affect how we use it in the CI. I have currently set the base branch to release-ci on GH, the branch for #1052 instead of main as the diff would make more sense that way.

Type of change

  • 🌻 Feature
  • 🐛 Bugfix
  • 🗺️ Documentation
  • 🤖 Test
  • 💻 CI/Deployment
  • 🐹 Trivial/Minor

Issue(s)

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@meain meain requested review from vkamra and ryanfkeepers October 7, 2022 11:15
Base automatically changed from release-ci to main October 10, 2022 05:30
@meain meain temporarily deployed to Testing October 10, 2022 05:34 Inactive
@meain meain marked this pull request as ready for review October 10, 2022 05:35
@meain meain temporarily deployed to Testing October 10, 2022 05:35 Inactive
@meain meain temporarily deployed to Testing October 10, 2022 05:35 Inactive
@meain meain temporarily deployed to Testing October 10, 2022 05:45 Inactive
@meain meain temporarily deployed to Testing October 10, 2022 05:46 Inactive
@meain meain temporarily deployed to Testing October 10, 2022 05:46 Inactive
@meain meain temporarily deployed to Testing October 10, 2022 05:47 Inactive
@meain meain temporarily deployed to Testing October 10, 2022 09:06 Inactive
@meain meain temporarily deployed to Testing October 10, 2022 09:07 Inactive
@meain meain temporarily deployed to Testing October 10, 2022 09:07 Inactive
@meain meain temporarily deployed to Testing October 10, 2022 09:08 Inactive
@meain meain mentioned this pull request Oct 10, 2022
Merged
9 tasks
@meain meain temporarily deployed to Testing October 11, 2022 03:27 Inactive
@meain meain temporarily deployed to Testing October 11, 2022 03:28 Inactive
@meain meain temporarily deployed to Testing October 11, 2022 11:10 Inactive
@meain meain temporarily deployed to Testing October 11, 2022 11:11 Inactive
@meain meain temporarily deployed to Testing October 11, 2022 11:11 Inactive
@meain meain temporarily deployed to Testing October 11, 2022 11:12 Inactive
@meain meain temporarily deployed to Testing October 11, 2022 11:43 Inactive
@meain meain temporarily deployed to Testing October 11, 2022 11:43 Inactive
@meain meain temporarily deployed to Testing October 11, 2022 11:43 Inactive
@meain meain temporarily deployed to Testing October 11, 2022 11:43 Inactive
@meain meain mentioned this pull request Oct 13, 2022
Closed
@meain meain temporarily deployed to Testing October 13, 2022 05:03 Inactive
@meain meain temporarily deployed to Testing October 13, 2022 05:03 Inactive
@meain meain temporarily deployed to Testing October 13, 2022 05:03 Inactive
@meain meain temporarily deployed to Testing October 13, 2022 05:04 Inactive
@aviator-app
Copy link
Contributor

aviator-app bot commented Oct 14, 2022 •
edited
Loading

Aviator status

Aviator will automatically update this comment as the status of the PR changes.

This PR was merged using Aviator.

@aviator-app aviator-app bot temporarily deployed to Testing October 14, 2022 03:19 Inactive
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@aviator-app aviator-app bot temporarily deployed to Testing October 14, 2022 03:19 Inactive
@aviator-app aviator-app bot temporarily deployed to Testing October 14, 2022 03:19 Inactive
@aviator-app aviator-app bot temporarily deployed to Testing October 14, 2022 03:19 Inactive
@aviator-app aviator-app bot merged commit 2d30f4a into main Oct 14, 2022
@aviator-app aviator-app bot deleted the met-bt branch October 14, 2022 03:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vkamra vkamra vkamra left review comments

@ryanfkeepers ryanfkeepers ryanfkeepers approved these changes

Assignees

@meain meain

Labels
mergequeue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@meain @vkamra @ryanfkeepers