This repository has been archived by the owner on Oct 11, 2024. It is now read-only.
Add corso version using ldflags #1104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
meain
force-pushed
the
met-bt
branch
2 times, most recently
from
b24ef0b to
5bd2754
Compare
ryanfkeepers
approved these changes
Oct 13, 2022
Aviator status
This PR was merged manually. Merging manually can negatively impact the performance of the queue. Consider using the |
|
Kudos, SonarCloud Quality Gate passed!
|
|
PR failed to merge with reason: some CI status(es) failed. |
meain
added
mergequeue
and removed
blocked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes
--versionwork with actual build version added using ldflags as mentioned in #1088 (comment) .Waiting for #1088 as this builds on top of that. Currently raised against the branch for that PR.
Type of change
Issue(s)
Test Plan