gossip: demote invalid duplicate proof errors to info #2754
Conversation
|
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
gossip/src/duplicate_shred.rs
Outdated
| impl Error { | ||
| /// Errors indicating that the initial node submitted an invalid duplicate proof case | ||
| pub(crate) fn is_non_critical(&self) -> bool { | ||
| matches!( |
There was a problem hiding this comment.
I would rather we explicitly list every enum variant and what is critical and what is not, similar to:
https://rust-lang.github.io/rust-clippy/master/index.html#/wildcard_enum_match_arm
but I guess not much an issue here.
AshwinSekar
added
the
automerge
* gossip: demote invalid duplicate proof errors to info * pr feedback: explicitly list every enum (cherry picked from commit 7b6e6c1)
… of #2754) (#2759) gossip: demote invalid duplicate proof errors to info (#2754) * gossip: demote invalid duplicate proof errors to info * pr feedback: explicitly list every enum (cherry picked from commit 7b6e6c1) Co-authored-by: Ashwin Sekar <[email protected]>
* gossip: demote invalid duplicate proof errors to info * pr feedback: explicitly list every enum
Problem
Misconfigured or malicious nodes can send out duplicate proofs that are invalid.
This will result in a lot of ERROR log spam.
Summary of Changes
Separate out logging to use INFO for invalid duplicate proofs, and ERROR for errors in the processing pipeline.